Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #888 Fatal error when having image size with integer name #892

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Closes #888 Fatal error when having image size with integer name #892

merged 1 commit into from
Sep 30, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Aug 12, 2024 •
edited
Loading

Description

Fixes #888

Documentation

User documentation

Should work as expected without any impact

Technical documentation

Type cast integer image size name to string

Type of change

  • Bug fix (non-breaking change which fixes an issue).

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I did not introduce unecessary complexity.

@Khadreal Khadreal self-assigned this Aug 12, 2024
@MathieuLamiot MathieuLamiot requested a review from a team August 12, 2024 11:35
wordpressfan
wordpressfan approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@wordpressfan wordpressfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job

Mai-Saad
Mai-Saad reviewed Aug 14, 2024
View reviewed changes
Copy link

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproducible steps:
1- Add snippet in the functions.php of active theme
2- fresh install /activate of imagify
3- Upload large image
4- click optimize 1 missing thumbnail link
marchlarge1

@wordpressfan
Copy link
Contributor

@Khadreal @Mai-Saad @piotrbak I believe we need to merge this one, correct?

@piotrbak
Copy link

@wordpressfan Yes

@wordpressfan wordpressfan added this pull request to the merge queue Sep 30, 2024
Merged via the queue into develop with commit 045f9f7 Sep 30, 2024
5 checks passed
@wordpressfan wordpressfan deleted the fix/888-fatal-error-image-size-integer branch September 30, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mai-Saad Mai-Saad Mai-Saad left review comments

@wordpressfan wordpressfan wordpressfan approved these changes

Assignees

@Khadreal Khadreal

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error when having image size with integer name
4 participants
@Khadreal @wordpressfan @piotrbak @Mai-Saad