Closes #898 Update close icon on upsell banners and admin bar #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wordpressfan
approved these changes
Sep 30, 2024
Mai-Saad
reviewed
Oct 1, 2024
| @@ -35,7 +35,7 @@ | |||
| <?php endif; ?> | |||
| <p><?php echo $data['text']; ?></p> | |||
| <p class="center txt-center text-center"><a class="imagify-upsell-admin-bar-button" href="<?php echo esc_url( $data['upgrade_link'] ); ?>" target="_blank"><?php echo $data['button_text']; ?></a></p> | |||
| <a href="<?php echo esc_url( get_imagify_admin_url( 'dismiss-notice', 'upsell-admin-bar' ) ); ?>" class="imagify-notice-dismiss imagify-upsell-dismiss" title="<?php esc_attr_e( 'Dismiss this notice', 'imagify' ); ?>"><span class="screen-reader-text"><?php esc_html_e( 'Dismiss this notice', 'imagify' ); ?></span></a> | |||
| <a href="<?php echo esc_url( get_imagify_admin_url( 'dismiss-notice', 'upsell-admin-bar' ) ); ?>" class="imagify-notice-dismiss imagify-upsell-dismiss notice-dismiss" title="<?php esc_attr_e( 'Dismiss this notice', 'imagify' ); ?>"><span class="screen-reader-text"><?php esc_html_e( 'Dismiss this notice', 'imagify' ); ?></span></a> | |||
There was a problem hiding this comment.
@Tabrisrp Is there a reason that we didn't remove imagify-upsell-dismiss here while we removed it in part-upsell.php file?
|
@Tabrisrp Thanks for the PR. @Tabrisrp Any idea why 2,3 has the icon grey and may be underlined? |
|
I pushed an update for the CSS for cases 2 and 3. |
|
Thanks, @Tabrisrp Looks good now. |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #898
Update close icon to use default icon from WP
Type of change
Detailed scenario
Technical description
Documentation
Updated class used + CSS color
Mandatory Checklist
Code validation
Code style