Release v1.0.6 #29
Merged
Release v1.0.6 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* start adding the beaconlrc class * finalize the beacon manager class * temporarily fix tests * Return only hash as payload * Remove duplicate payload * Only add child element below the fold threshold and parent elements only below the fold * use config threshold instead of static value * Revert "use config threshold instead of static value" This reverts commit b4f633b. * use logger class and comment the xpath for now * Replace static values with config * start doing as grooming * get only elements that have hash * Added test for lrc * Best practices * Additional best practices * start considering viewport on element distance calculation * adjust imports and the log message * change the structure of test to handle more cases and use sinon for mocking * test * test 2 * fix tests attempt 1 * add more tests * add tests for run method * add more tests * remove not used argument --------- Co-authored-by: Michael Lee <[email protected]> Co-authored-by: Mathieu Lamiot <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog