more review modifications

wp-media · Feb 13, 2024 · a5d5204 · a5d5204
1 parent fa4d865
commit a5d5204
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 85 deletions.
diff --git a/.gitignore b/.gitignore
@@ -13,4 +13,5 @@
 /backstop_data/bitmaps_test
 /backstop_data/html_report
 .DS_Store
-.idea
+.idea
+backstop.json
diff --git a/backstop.json b/backstop.json
@@ -8,86 +8,6 @@
     }
   ],
   "scenarios": [
-    {
-      "label": "home",
-      "url": "https://e2e.rocketlabsqa.ovh/",
-      "referenceUrl": "",
-      "readyEvent": "",
-      "readySelector": "",
-      "delay": 0,
-      "hideSelectors": [],
-      "removeSelectors": [],
-      "hoverSelector": "",
-      "clickSelector": "",
-      "postInteractionWait": 0,
-      "selectors": [],
-      "selectorExpansion": true,
-      "expect": 0,
-      "misMatchThreshold": 0.1,
-      "requireSameDimensions": true,
-      "onReadyScript": "scrollToBottom.js",
-      "onBeforeScript": ""
-    },
-    {
-      "label": "llcss",
-      "url": "https://e2e.rocketlabsqa.ovh/lazyload_css_background_images",
-      "referenceUrl": "",
-      "readyEvent": "",
-      "readySelector": "",
-      "delay": 0,
-      "hideSelectors": [],
-      "removeSelectors": [],
-      "hoverSelector": "",
-      "clickSelector": "",
-      "postInteractionWait": 0,
-      "selectors": [],
-      "selectorExpansion": true,
-      "expect": 0,
-      "misMatchThreshold": 0.1,
-      "requireSameDimensions": true,
-      "onReadyScript": "scrollToBottom.js",
-      "onBeforeScript": ""
-    },
-    {
-      "label": "noJsLlcss",
-      "url": "https://e2e.rocketlabsqa.ovh/lazyload_css_background_images",
-      "referenceUrl": "",
-      "readyEvent": "",
-      "readySelector": "",
-      "delay": 0,
-      "hideSelectors": [],
-      "removeSelectors": [],
-      "hoverSelector": "",
-      "clickSelector": "",
-      "postInteractionWait": 0,
-      "selectors": [],
-      "selectorExpansion": true,
-      "expect": 0,
-      "misMatchThreshold": 0.1,
-      "requireSameDimensions": true,
-      "onReadyScript": "wait.js",
-      "onBeforeScript": "disableJavascript.js"
-    },
-    {
-      "label": "elementorLlcss",
-      "url": "https://e2e.rocketlabsqa.ovh/elementor-overlay",
-      "referenceUrl": "",
-      "readyEvent": "",
-      "readySelector": "",
-      "delay": 0,
-      "hideSelectors": [],
-      "removeSelectors": [],
-      "hoverSelector": "",
-      "clickSelector": "",
-      "postInteractionWait": 0,
-      "selectors": [],
-      "selectorExpansion": true,
-      "expect": 0,
-      "misMatchThreshold": 0.1,
-      "requireSameDimensions": true,
-      "onReadyScript": "scrollToBottom.js",
-      "onBeforeScript": ""
-    }
   ],
   "paths": {
     "bitmaps_reference": "backstop_data/bitmaps_reference",

diff --git a/src/features/wpml-compatibility.feature b/src/features/wpml-compatibility.feature
@@ -7,8 +7,8 @@ Feature: C14655 - Should LL Background work on main/sub language
       When I go to 'wp-admin/options-general.php?page=wprocket#dashboard'
       And I save settings 'media' 'lazyloadCssBgImg'
       Given activate 'wpml-multilingual-cms' plugin
-      Given wpml has more than one languages
-      Given wpml directory is enabled
+      And wpml has more than one languages
+      And wpml directory is enabled
 
     Scenario: Open the page with directory lanaguage
       Then no error in the console different than nowprocket page 'llcss'

diff --git a/src/support/steps/wpml.ts b/src/support/steps/wpml.ts
@@ -81,8 +81,8 @@ Given('wpml has more than one languages', async function (this:ICustomWorld) {
 /**
  * Switch to another language
  */
-When('switch to another language', async function () {
-    const getNextLanguageAnchor = await this.page.locator('.wpml-ls-slot-footer a:not(.wpml-ls-current-language)').first()
+When('switch to another language', async function (this:ICustomWorld) {
+    const getNextLanguageAnchor = this.page.locator('.wpml-ls-slot-footer a:not(.wpml-ls-current-language)').first()
     const getLink = await getNextLanguageAnchor.getAttribute('href');
     await this.page.goto(getLink)