Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #140: Isolate VR Tests to be generic for all WPR features #182

Conversation

jeawhanlee
Copy link
Contributor

Description

Fixes #140
Allows Visual Regression tests to be run against any WPR feature.

Type of change

  • New feature (non-breaking change which adds functionality).
  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

N/A

Technical description

Documentation

Visual Regression tests can now be run against any WPR feature by just running:
npm run test:vr --wproption=rucss where rucss is a recognized option in the testsuite, full reference of options that can be parsed are found here: https://github.com/wp-media/wp-rocket-e2e/blob/8e61ff1f734b8784aa2198f6fb2b96aa3ca2cf3f/src/common/selectors.ts

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

  • No built-in test to implement
  • No entry points to protect

@jeawhanlee jeawhanlee self-assigned this Jan 9, 2025
@jeawhanlee jeawhanlee added the enhancement New feature or request label Jan 9, 2025
@jeawhanlee jeawhanlee requested a review from a team January 9, 2025 13:00
Khadreal
Khadreal previously approved these changes Jan 10, 2025
This was referenced Jan 13, 2025
Copy link
Contributor

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • checked PR with new cmd i.e npm run test:vr --wproption=lazyloadCssBgImg
  • check PR with old suit having VR i.e npm run test:llcssbg
  • Both are woking , noting that at backstop , some templates may fail (templates will be revisited in separate GH)
    Screenshot from 2025-01-13 11-44-52
    Screenshot from 2025-01-13 11-06-34

@Mai-Saad
Copy link
Contributor

smoke test
Screenshot from 2025-01-13 12-13-36

@Mai-Saad Mai-Saad merged commit 0689842 into develop Jan 13, 2025
2 checks passed
@Mai-Saad Mai-Saad deleted the enhancement/140-isolate-vr-tests-to-be-generic-for-all-wpr-features branch January 13, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolate VR Tests to be generic for all WPR features
3 participants