-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #140: Isolate VR Tests to be generic for all WPR features #182
Merged
Mai-Saad
merged 9 commits into
develop
from
enhancement/140-isolate-vr-tests-to-be-generic-for-all-wpr-features
Jan 13, 2025
Merged
Closes #140: Isolate VR Tests to be generic for all WPR features #182
Mai-Saad
merged 9 commits into
develop
from
enhancement/140-isolate-vr-tests-to-be-generic-for-all-wpr-features
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khadreal
previously approved these changes
Jan 10, 2025
…neric-for-all-wpr-features
Mai-Saad
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mai-Saad
deleted the
enhancement/140-isolate-vr-tests-to-be-generic-for-all-wpr-features
branch
January 13, 2025 10:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #140
Allows Visual Regression tests to be run against any WPR feature.
Type of change
Detailed scenario
N/A
Technical description
Documentation
Visual Regression tests can now be run against any WPR feature by just running:
npm run test:vr --wproption=rucss where rucss is a recognized option in the testsuite, full reference of options that can be parsed are found here: https://github.com/wp-media/wp-rocket-e2e/blob/8e61ff1f734b8784aa2198f6fb2b96aa3ca2cf3f/src/common/selectors.ts
New dependencies
N/A
Risks
N/A
Mandatory Checklist
Code validation
Code style
Unticked items justification