Merge dev Version to trunk and release 1.1.0 #194

Mai-Saad · 2025-01-13T14:11:34Z

Description

This PR to merge e2e fixes to the trunk and release e2e 1.1.0

Type of change

New feature (non-breaking change which adds functionality).
Bug fix (non-breaking change which fixes an issue).
Enhancement (non-breaking change which improves an existing functionality).
Breaking change (fix or feature that would cause existing functionality to not work as before).
Sub-task of #(issue number)
Chore
Release

List any new dependencies that are required for this change.

The config file shall be updated as per the sample-config.ts file
Admin 2 is needed on test env (credentials data is needed in config file to be used in test)
imagify key is needed in the config file to be used in the test

Risks

None

Mandatory Checklist

Code validation

I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
I triggered all changed lines of code at least once without new errors/warnings/notices.
I implemented built-in tests to cover the new/changed code.

Code style

I wrote a self-explanatory code about what it does.
I protected entry points against unexpected inputs.
I did not introduce unnecessary complexity.
Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

If some mandatory items are not relevant, explain why in this section.

Additional Checks

In the case of complex code, I wrote comments to explain it.
When possible, I prepared ways to observe the implemented system (logs, data, etc.).
I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

…lcp-beacon-name" This reverts commit b6606a9, reversing changes made to 3d53029.

…-change-lcp-beacon-name"" This reverts commit ca35844.

GH action to create a release on trunk

removed the ‘after’ property from minify_css and minify_js

…ch priority feature , renamed the feature and re-organized steps

…ll this function

Refactor cache clear step and logout

…e all options

…y be already deleted

…ns and reorder steps for export after update but still need some work there

…ettings

Closes #121 Add "comments" in the JSON of expected results

Fix #177 CPCSS notice has scenario that won't work correctly now due to the login structure

…-errors-relating-to-wpr

…g-log-with-errors-relating-to-wpr Closes #67: Only rename debug.log with errors relating to WPR

…d in the cli

…it (PR #174) * :closes: #143 add process to rename and push test files to git * Add PAT variable to config * Add option to initialised for empty directory * Fix import error * Add bash script and modify report file * Remove unused variable, clean up report file -- #143 * Modify bash script * Update scripts and command * Change the default destination directory * Modify scripts, deleted bash script --#143 * Refactor script and command, revert config modifications * Modify command to make sure subsequent commands run --------- Co-authored-by: Mai <[email protected]>

Closes #129 Automate the scenario that check LL isnot applied on LCP/ATF images

…-warning Closes #183: Operation not permitted warning on dev latest commit

…neric-for-all-wpr-features

…s-to-be-generic-for-all-wpr-features Closes #140: Isolate VR Tests to be generic for all WPR features

Mai-Saad · 2025-01-13T14:13:50Z

e2e report is on the shared folder /var/shared/rocket-e2e-reports/wpr3.18_e2edev1.1.0_all

MathieuLamiot and others added 30 commits July 31, 2024 16:30

Revert "Merge pull request #125 from wp-media/enhancement/124-change-…

ca35844

…lcp-beacon-name" This reverts commit b6606a9, reversing changes made to 3d53029.

Revert "Revert "Merge pull request #125 from wp-media/enhancement/124…

06194ce

…-change-lcp-beacon-name"" This reverts commit ca35844.

GH action to create a release on trunk

2dc5a02

Merge pull request #128 from wp-media/enhancement/release-flow

4f89614

GH action to create a release on trunk

removed the ‘after’ property from minify_css and minify_js

83ed6a7

Merge pull request #134 from wp-media/remove-after-property-from-miinify

4b9d7bc

removed the ‘after’ property from minify_css and minify_js

updated cache clear to assert the notice, removed scroll from the fet…

a47e0e1

…ch priority feature , renamed the feature and re-organized steps

update logout to assert on notice instead of waitForLoadState

c382d55

removed unneeded other waitForLoadState for logout

1bbc2e2

removed unnecessary if condition. if we can't logout, we shouldn't ca…

01c0665

…ll this function

Merge pull request #135 from wp-media/enhancement/refactor-clear-cache

6f98cf7

Refactor cache clear step and logout

Add GH Action PR template checker

ffbb4e7

Add comments to lcp json :closes: #121

eecef07

Add comment to script function

e067b99

refactor rollback related steps

da2b973

refactor enable all options

16385e3

refactor page load successfully step and login

3ed3020

refactor plugin install

270669f

remove wait when check that no error in debug.log

e7e1f10

remove wait from delete plugin

f6abd21

remove load from import settings, save settings user cache and disabl…

7573ebd

…e all options

:closes: #137 add new urls to config

9106400

using plugins page to confirm no debug error instead of WPR as wpr ma…

877af86

…y be already deleted

adjust data imported test as it's validated across all disabled optio…

da0d447

…ns and reorder steps for export after update but still need some work there

removed unneeded save step as save is already in disable/enable all s…

da3a717

…ettings

moved if condition to successfully deleted step

1fbb049

added condition to switch to tools page if it wasnot open

50e48e7

modified page utils to avoid possible error

7e75568

Merge pull request #139 from wp-media/enhancement/121-json-comments

704cdd4

Closes #121 Add "comments" in the JSON of expected results

tmp

aceccd2

Khadreal and others added 26 commits January 7, 2025 17:02

✨ Make code anti-DRY

6656a3b

Merge pull request #180 from wp-media/fix/177-cpcss-notice

36f8526

Fix #177 CPCSS notice has scenario that won't work correctly now due to the login structure

Update patterns

e5b7d01

Merge branch 'develop' into enhancement/67-only-rename-debug-log-with…

acec67e

…-errors-relating-to-wpr

Merge pull request #181 from wp-media/enhancement/67-only-rename-debu…

1204467

…g-log-with-errors-relating-to-wpr Closes #67: Only rename debug.log with errors relating to WPR

Move function to helper file

1f5446e

Modify scenario name

a24f6a2

Merge branch 'develop' into feature/129-ll-not-applied-lcp

51576aa

Clean up, fix error

b884006

Change test tag, add more step to lcp test

86e530d

Added new hook for vr tag with support for cli argument for wpr option

b9c5437

New step definition to enable and save new option from argument passe…

7cd0d7f

…d in the cli

Updated vr feature

196635d

Added new property

4ccb840

Added new scenario url for vr test

eaadba1

Updated script command

fe79fc1

Fixed conflicts

4a2a25f

Remove redundant step and add Youtube lazyload option

2ac30d7

Make execution run silently

e5deb0c

Merge branch 'develop' into feature/129-ll-not-applied-lcp

d21bfa4

Merge pull request #144 from wp-media/feature/129-ll-not-applied-lcp

7c06faa

Closes #129 Automate the scenario that check LL isnot applied on LCP/ATF images

Fixed conflicts

bb134b4

Merge pull request #188 from wp-media/fix/183-operation-not-permitted…

2617e94

…-warning Closes #183: Operation not permitted warning on dev latest commit

Merge branch 'develop' into enhancement/140-isolate-vr-tests-to-be-ge…

e818d7d

…neric-for-all-wpr-features

Merge pull request #182 from wp-media/enhancement/140-isolate-vr-test…

0689842

…s-to-be-generic-for-all-wpr-features Closes #140: Isolate VR Tests to be generic for all WPR features

Mai-Saad requested a review from a team January 13, 2025 14:29

Khadreal approved these changes Jan 13, 2025

View reviewed changes

Mai-Saad merged commit 6a883f5 into trunk Jan 13, 2025
6 of 15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge dev Version to trunk and release 1.1.0 #194

Merge dev Version to trunk and release 1.1.0 #194

Mai-Saad commented Jan 13, 2025 •

edited

Loading

Mai-Saad commented Jan 13, 2025

Merge dev Version to trunk and release 1.1.0 #194

Merge dev Version to trunk and release 1.1.0 #194

Conversation

Mai-Saad commented Jan 13, 2025 • edited Loading

Description

Type of change

Risks

Mandatory Checklist

Code validation

Code style

Unticked items justification

Additional Checks

Mai-Saad commented Jan 13, 2025

Mai-Saad commented Jan 13, 2025 •

edited

Loading