Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step one test for wpml #46

Merged
merged 13 commits into from
Apr 3, 2024
Merged

Add step one test for wpml #46

merged 13 commits into from
Apr 3, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Feb 8, 2024

Description

To run this test, run this command npm run test:wpml

Fixes #23

Type of change

  • New feature (non-breaking change which adds functionality).

Is the solution different from the one proposed during the grooming?

Please describe in this section if there is any change to the groomed solution, and why.

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

@Khadreal Khadreal requested a review from jeawhanlee February 8, 2024 14:38
@Khadreal Khadreal marked this pull request as ready for review February 9, 2024 11:22
src/features/wpml-compatibility.feature Outdated Show resolved Hide resolved
utils/page-utils.ts Outdated Show resolved Hide resolved
src/support/steps/wpml.ts Outdated Show resolved Hide resolved
src/support/steps/wpml.ts Outdated Show resolved Hide resolved
src/support/steps/wpml.ts Outdated Show resolved Hide resolved
src/support/steps/wpml.ts Outdated Show resolved Hide resolved
src/support/steps/general.ts Outdated Show resolved Hide resolved
src/support/steps/general.ts Outdated Show resolved Hide resolved
src/features/wpml-compatibility.feature Outdated Show resolved Hide resolved
src/features/wpml-compatibility.feature Outdated Show resolved Hide resolved
backstop.json Show resolved Hide resolved
src/features/wpml-compatibility.feature Outdated Show resolved Hide resolved
src/support/steps/wpml.ts Outdated Show resolved Hide resolved
backstop.json Show resolved Hide resolved
jeawhanlee
jeawhanlee previously approved these changes Feb 13, 2024
@MathieuLamiot
Copy link
Contributor

Need #45 merged first

@jeawhanlee
Copy link
Contributor

@Khadreal Could you merge trunk into this PR branch to keep it updated.

Copy link
Contributor

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be in order. Both scenarios have passed on my end. The steps accurately perform or verify what's required. I have also validated that the steps correspond with those in TestRail.

@hanna-meda hanna-meda merged commit 778efaf into trunk Apr 3, 2024
1 check passed
@hanna-meda hanna-meda deleted the wpml-compatibility#23 branch April 3, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoke test for WPML Compatibility
4 participants