Closes #59: Deletes or rename debug.log file before tests
#60
Conversation
src/support/hooks.ts
Outdated
| const debugLogExists = await exists(debugLogPath); | ||
|
|
||
| if (debugLogExists) { | ||
| await rm(debugLogPath); |
There was a problem hiding this comment.
I believe we should not only remove the debug.log but every scenario debug.log so we don't have unnecessary logs piled up over time.
There was a problem hiding this comment.
Maybe @wp-media/qa-team can help here, if they have a preference?
There was a problem hiding this comment.
Umm, yea that's not a bad idea.
We could do delete everything that ends by .log
There was a problem hiding this comment.
I agree with removing them from all places.
jeawhanlee
dismissed
their stale review
There was an oversight while I was reviewing
|
@Miraeld, @jeawhanlee, me and @Mai-Saad tested this, and here are the conclusions:
We tested by having a page template added to a test, that triggered a PHP fatal error in the debug.log file
Expected here would be that we rename the debug.log for every scenario that creates it irrespective of whether the error it’s wpr related or not. |
|
Thanks @hanna-meda I pushed a fix for this. |
There was a problem hiding this comment.
debug.log entries are deleting before running tests ✓
debug.log file is suffixed by the scenario name during which errors were caught ✓
- if errors contain any of the patterns:
/plugins/wp-rocket/
wpr_rucss_used_css
wpr_rocket_cache
scenario(s) will fail - if any other error, not wpr related, the scenario will be passed.
Description
Fixes #59
Documentation
User documentation
It will deletes the
debug.logbefore running tests, and once the test process is started, it will renamedebug.logif it exists todebug-{previousTestName.log.It requires to setup the
sshenvironment within thewp.config.tsto work.Technical documentation
Type of change
Delete options that are not relevant.
New dependencies
Risks
Checklists
Feature validation