Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #57: Test that beacon script captures right image on template #64

Merged

Conversation

jeawhanlee
Copy link
Contributor

@jeawhanlee jeawhanlee commented Apr 4, 2024

Description

Test that the Beacon script returns expected LCP & ATF

Fixes #57

Documentation

Technical documentation

  • First install new dependencies, npm install
  • Need to add necessary SSH credentials in the wp.config
    WP_ENV_TYPE = 'external',
    WP_SSH_USERNAME = '',
    WP_SSH_ADDRESS = '',
    WP_SSH_KEY = 'path/to/private/key',
    WP_SSH_ROOT_DIR = '/path/to/e2e/root/dir/on/server'
    
  • To run we have a new script: npm run test:lcp

Type of change

  • New feature (non-breaking change which adds functionality).

New dependencies

Axios for getting PSI data.

@jeawhanlee jeawhanlee added the test New test label Apr 4, 2024
@jeawhanlee jeawhanlee self-assigned this Apr 4, 2024
@jeawhanlee jeawhanlee marked this pull request as ready for review April 4, 2024 10:36
@jeawhanlee jeawhanlee requested a review from a team April 4, 2024 10:36
@jeawhanlee jeawhanlee changed the title Test/57 beacon script captures right image on template Closes #57: Test that beacon script captures right image on template Apr 4, 2024
Khadreal
Khadreal previously approved these changes Apr 4, 2024
Copy link
Contributor

@Khadreal Khadreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Apr 5, 2024

Working fine for sample test data (tests are failing either cause of known issue or case that needs investigation)

Next:
1- add the rest of test data (can be on separate PR)

@Mai-Saad Mai-Saad merged commit 52a88c4 into trunk Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test New test
Projects
None yet
3 participants