-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #57: Test that beacon script captures right image on template #64
Merged
Mai-Saad
merged 15 commits into
trunk
from
test/57-beacon-script-captures-right-image-on-template
Apr 5, 2024
Merged
Closes #57: Test that beacon script captures right image on template #64
Mai-Saad
merged 15 commits into
trunk
from
test/57-beacon-script-captures-right-image-on-template
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeawhanlee
changed the title
Test/57 beacon script captures right image on template
Closes #57: Test that beacon script captures right image on template
Apr 4, 2024
Khadreal
previously approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mai-Saad
reviewed
Apr 5, 2024
Khadreal
approved these changes
Apr 5, 2024
Working fine for sample test data (tests are failing either cause of known issue or case that needs investigation) Next: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test that the Beacon script returns expected LCP & ATF
Fixes #57
Documentation
Technical documentation
npm install
npm run test:lcp
Type of change
New dependencies
Axios for getting PSI data.