Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/fix rucss job crash due to cast #6257

Merged
merged 11 commits into from
Nov 2, 2023

Conversation

CrochetFeve0251
Copy link
Contributor

Description

Fix an error on rucss due to a casting error on trunk.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

@CrochetFeve0251 CrochetFeve0251 self-assigned this Oct 31, 2023
@CrochetFeve0251 CrochetFeve0251 requested a review from a team October 31, 2023 15:11
@vmanthos vmanthos self-requested a review November 1, 2023 06:43
Copy link
Contributor

@vmanthos vmanthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't possible to reproduce the issue with 3.15.2 or 3.15.3.

Tested the PR for regressions, and everything is working fine. 👍

@vmanthos vmanthos added this to the 3.15.4 milestone Nov 2, 2023
@vmanthos vmanthos added this pull request to the merge queue Nov 2, 2023
Merged via the queue into develop with commit adf12cc Nov 2, 2023
8 checks passed
@vmanthos vmanthos deleted the bug/fix-rucss-job-crash-due-to-cast branch November 2, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants