Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUCSS] Fix modified column not being updated in some cases #6259

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

wordpressfan
Copy link
Contributor

Description

We found a bug in the columns definitions for RUCSS database table that prevents BerlinDB from identifying the modified column to be updated with any update in the table.

Fixes #6229

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

As groomed

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@wordpressfan wordpressfan self-assigned this Nov 2, 2023
@wordpressfan wordpressfan requested a review from a team November 2, 2023 07:58
Copy link
Contributor

@mostafa-hisham mostafa-hisham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@vmanthos vmanthos self-requested a review November 2, 2023 11:10
Copy link
Contributor

@vmanthos vmanthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected! 👍

@vmanthos vmanthos added this to the 3.15.5 milestone Nov 17, 2023
@vmanthos vmanthos added this pull request to the merge queue Nov 17, 2023
Merged via the queue into develop with commit 2645eeb Nov 17, 2023
8 checks passed
@vmanthos vmanthos deleted the fix/6229-RUCSS-modified-not-updated-properly branch November 17, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modified date isnot changed when change status / retries of RUCSS
4 participants