Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the LRC Factory in the PerformanceHints #6888

Merged
merged 13 commits into from
Aug 22, 2024

Conversation

jeawhanlee
Copy link
Contributor

@jeawhanlee jeawhanlee commented Aug 22, 2024

Description

This PR fixes the issue of LRC Beacon bailing out by adding the LRC Factory to the PerformanceHints ServiceProvider.
This will unlock #6874 & #6828

Documentation

User documentation

LRC Candidates can now be stored and ready for optimizations to be applied.

Technical documentation

We added the LRC factory to the PerformanceHints ServiceProvider and also implemented the ControllerInterface in Engine\Optimization\LazyRenderContent\Frontend\Controller and the must-implement methods.

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).

New dependencies

N/A

Risks

N/A

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@jeawhanlee jeawhanlee added the module: ALR Issues related to the Automatic Lazy Rendering feature label Aug 22, 2024
@jeawhanlee jeawhanlee self-assigned this Aug 22, 2024
@jeawhanlee jeawhanlee changed the base branch from feature/lrc-functionality-script to feature/lrc August 22, 2024 13:53
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d04a63b1 0.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d04a63b) Report Missing Report Missing Report Missing
Head commit (e536d02) 37855 14431 38.12%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6888) 10 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jeawhanlee jeawhanlee requested a review from a team August 22, 2024 15:14
@jeawhanlee jeawhanlee added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Aug 22, 2024
@jeawhanlee jeawhanlee marked this pull request as ready for review August 22, 2024 15:14
@Tabrisrp Tabrisrp added this to the 3.17 milestone Aug 22, 2024
@jeawhanlee jeawhanlee merged commit bea83ff into feature/lrc Aug 22, 2024
10 of 11 checks passed
@jeawhanlee jeawhanlee deleted the fix/register-lrc-factory-in-serviceprovider branch August 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: ALR Issues related to the Automatic Lazy Rendering feature type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants