-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the LRC Factory in the PerformanceHints #6888
Add the LRC Factory in the PerformanceHints #6888
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Description
This PR fixes the issue of LRC Beacon bailing out by adding the LRC Factory to the PerformanceHints ServiceProvider.
This will unlock #6874 & #6828
Documentation
User documentation
LRC Candidates can now be stored and ready for optimizations to be applied.
Technical documentation
We added the LRC factory to the PerformanceHints ServiceProvider and also implemented the ControllerInterface in
Engine\Optimization\LazyRenderContent\Frontend\Controller
and the must-implement methods.Type of change
New dependencies
N/A
Risks
N/A
Checklists
Feature validation
Documentation
Code style