Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.18 main features #7165

Merged
merged 12 commits into from
Jan 3, 2025
Merged

3.18 main features #7165

merged 12 commits into from
Jan 3, 2025

Conversation

wordpressfan
Copy link
Contributor

@wordpressfan wordpressfan commented Dec 3, 2024

Description

Fixes #(issue number)

Before merging this PR, we need to make sure that v2 endpoints are deployed to our SaaS backend (https://github.com/wp-media/rucss-backend/issues/149#issuecomment-2475466364)

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Chore
  • Release

Detailed scenario

Explain how to reproduce the issue (for bugs) or how to trigger the new code. You can refer to the GitHub issue or grooming if it is still applicable.

Technical description

Documentation

Explain how this code works. Diagrams & drawings are welcome.

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

If some mandatory items are not relevant, explain why in this section.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

Copy link

codacy-production bot commented Dec 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.47% (target: -0.10%) 71.79% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (dfe5a7a) 38258 16737 43.75%
Head commit (2b77a58) 38760 (+502) 17139 (+402) 44.22% (+0.47%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7165) 585 420 71.79%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@remyperona remyperona added this to the 3.18 milestone Dec 4, 2024
Miraeld and others added 7 commits December 9, 2024 16:10
# Conflicts:
#	assets/css/wpr-admin.min.css
#	assets/js/wpr-admin.js
#	assets/js/wpr-admin.min.js
#	assets/js/wpr-admin.min.js.map
#	src/js/global/fields.js
#	wp-rocket.php
Co-authored-by: Gael Robin <[email protected]>
Co-authored-by: Rémy Perona <[email protected]>
Co-authored-by: Rémy Perona <[email protected]>
Co-authored-by: Opeyemi Ibrahim <[email protected]>
Co-authored-by: Michael Lee <[email protected]>
Co-authored-by: hanna-meda <[email protected]>
@wordpressfan wordpressfan marked this pull request as ready for review January 1, 2025 07:43
@wordpressfan wordpressfan added this pull request to the merge queue Jan 3, 2025
@wordpressfan wordpressfan removed this pull request from the merge queue due to a manual request Jan 3, 2025
@wordpressfan wordpressfan added this pull request to the merge queue Jan 3, 2025
Merged via the queue into develop with commit 3a73b77 Jan 3, 2025
12 of 14 checks passed
@wordpressfan wordpressfan deleted the feature/3.18 branch January 3, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants