-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #6550 Delegate creation of the dependencies to the container #7215
base: develop
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For @wp-media/qa-team here we touched mostly all service providers, and this affects even thirdparty compatibility files, so good luck :D
Slack discussion to explain what we changed in that PR because we will use in our next development.
Also I believe we need to merge this ASAP not to get many conflicts while we are working on features in develop.
Thanks.
Description
Fixes #6550
Update the service providers code to pass the dependencies aliases instead of the instances of the classes when registering the services.
Type of change
Detailed scenario
The change doesn't have any impact on the functionality of the plugin itself.
Technical description
Documentation
Replaced the container calls to get the instances of dependencies by passing only the aliases directly. This delegates the instances creation to the container instead of it happening in the providers.
Also update string & array dependencies declaration to use the
StringArgument
andArrayArgument
classes, which helps the container know directly that the type of the value passed.Mandatory Checklist
Code validation
Code style