-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #159 - ${PostType}EditorBlock Interfaces registered and implemented with different names #160
Conversation
…ted with different names Instead of using the Post Type's name to register Interface Types, this uses the Post Type's graphql_single_name to register the Interface Types, which is consistent with what is used to implement the Types as Interfaces.
|
@jasonbahl Thanks I will take alook |
@jasonbahl LGTM. Can you also include a changeset as well? |
@theodesp I'll work on adding a test. I'm not sure how to add a changeset 👀 |
Hey @jasonbahl just run |
@theodesp @jasonbahl I added a changeset here. Let me know if you have thoughts on improving it. |
@mindctrl changeset looks good to me. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @theodesp @blakewilson one of you want to review too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Instead of using the Post Type's name to register Interface Types, this uses the Post Type's graphql_single_name to register the Interface Types, which is consistent with what is used to implement the Types as Interfaces.
closes #159