Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #159 - ${PostType}EditorBlock Interfaces registered and implemented with different names #160

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

jasonbahl
Copy link
Contributor

Instead of using the Post Type's name to register Interface Types, this uses the Post Type's graphql_single_name to register the Interface Types, which is consistent with what is used to implement the Types as Interfaces.

closes #159

…ted with different names

Instead of using the Post Type's name to register Interface Types, this uses the Post Type's graphql_single_name to register the Interface Types, which is consistent with what is used to implement the Types as Interfaces.
@jasonbahl jasonbahl self-assigned this Oct 23, 2023
@jasonbahl jasonbahl requested a review from a team as a code owner October 23, 2023 17:42
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

⚠️ No Changeset found

Latest commit: 9ef1ec4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theodesp
Copy link
Member

@jasonbahl Thanks I will take alook

@theodesp
Copy link
Member

@jasonbahl LGTM. Can you also include a changeset as well?

@jasonbahl
Copy link
Contributor Author

jasonbahl commented Oct 24, 2023

@theodesp I'll work on adding a test. I'm not sure how to add a changeset 👀

@theodesp
Copy link
Member

Hey @jasonbahl just run npm run changeset on the root folder it will ask you some questions about the change. It will create a new file inside .changesets folder that you need to commit

@mindctrl
Copy link
Contributor

@theodesp @jasonbahl I added a changeset here. Let me know if you have thoughts on improving it.

@jasonbahl
Copy link
Contributor Author

@mindctrl changeset looks good to me. Thanks!

Copy link
Contributor

@mindctrl mindctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @theodesp @blakewilson one of you want to review too?

Copy link
Member

@theodesp theodesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mindctrl mindctrl merged commit be7a34f into main Nov 29, 2023
7 checks passed
@mindctrl mindctrl deleted the fix/#159-EditorBlock-interface-names branch November 29, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

${PostType}EditorBlock Interfaces are being registered and implemented with different names
3 participants