chore: bump PHPStan to level 8 and generate baseline. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9e6394 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
justlevine
force-pushed
the
chore/phpstan-lvl-8
branch
2 times, most recently
from
c3aa5fa to
cd3d7db
Compare
justlevine
force-pushed
the
chore/phpstan-lvl-8
branch
from
cd3d7db to
c9e6394
Compare
|
(Apologies for the force pushes, accidentally started on the wrong base branch) |
mindctrl
approved these changes
Mar 25, 2024
|
Thanks @justlevine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR bumps the PHPStan ruleset to level 8, while adding a baseline to ignore existing PHP errors.
Why
It seems my previous PRs around code quality were too aspirational. By bumping the ruleset now we can prevent the introduction of even more PHP errors into the codebase, while providing a clear to-do list for the existing errors that need to be addressed.