Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont overload NodeWithEditorBlocks.flat #246

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

justlevine
Copy link
Contributor

What

This PR removes the unnecessary flat arg definition from NodeWith{$Post_Type}EditorBlocks, instead relying on the arg definition set by the parent NodeWithEditorBlocks.

Why

The real reason is that there is no difference between the parent and child implementations, so there's no reason to overload.

The superficial reason is that it works around a WPGraphQL core regression wp-graphql/wp-graphql#3152 which:

Screenshots

Look ma no extension.debug messages
image

@justlevine justlevine requested a review from a team as a code owner June 15, 2024 14:35
Copy link

changeset-bot bot commented Jun 15, 2024

🦋 Changeset detected

Latest commit: 6de0fde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/wp-graphql-content-blocks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

theodesp
theodesp previously approved these changes Jun 20, 2024
@theodesp
Copy link
Member

@justlevine we might need to resolve the conflicts before merging thanks!

@justlevine
Copy link
Contributor Author

@theodesp done in 6de0fde.

Seems the conflict was just whitespace...

@theodesp theodesp merged commit a910d62 into wpengine:main Jun 24, 2024
9 of 10 checks passed
@justlevine justlevine deleted the fix/dont-overload-flat branch June 24, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface field argument error in GraphQL IDE after update to WPGraphQL 1.26
2 participants