fix: prevent fatal errors with DOMHelpers methods by improving typesafety and returning early

[justlevine]

What

This PR:

• Updates the methods in the DOMHelpers class to return early if no HTML is passed to the method.
• Improves type safety of the DOMHelpers methods by inlining their types to the method signatures. To maintain back-compatiblity, the old methods have been deprecated, with snake_case alternatives created with the stricter signatures.

Important

This PR is based on #256 which should be merged first.
The relevant diff for this PR is: 5b59fe3

Why

Without returning early, numerous DIDOM methods we call internally can fatal error. The improved type safety is to prevent this sort of issue leaking through again in the future.

To Test

1. Add the following placeholder image block to a page (extracted from a TT4 pattern):

   <!-- wp:image {"width":"150px","aspectRatio":"4/3","scale":"contain","linkDestination":"none"} -->
   <figure class="wp-block-image is-resized"><img alt="" style="aspect-ratio:4/3;object-fit:contain;width:150px"/></figure>
   <!-- /wp:image -->

2. Query for CoreBlockImageAttributes:

   {
    nodeByUri(uri: "/sample-page") { # change the URI to your page
      ... on NodeWithEditorBlocks {
        editorBlocks {
          __typename
          ... on CoreImage {
            attributes {
              width
              alt
            }
          }
        }
      }
     }
   }

3. Ensure no errors, and attributes are returned.

Screenshots

• Before:
  

• After:
  

[changeset-bot]

🦋 Changeset detected

Latest commit: c83a124

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@wpengine/wp-graphql-content-blocks	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[justlevine]

@jasonbahl for your review

[theodesp]

@justlevine there is a small conflict there; if you could resolve it, I can merge. Thank you

The merge-base changed after approval.

[justlevine]

@theodesp conflicts resolved ✔️

[justlevine]

#258 will fix the failing ci

Please let me know what else I can do to help advance this ticket.

[theodesp]

@justlevine I merged #258

[justlevine]

@theodesp I merged main into the PR, If you trigger the CI again, you should see them all passing now (besides SonarQube)