feat: parse meta attributes
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9e94b89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
justlevine
force-pushed
the
feat/meta-attributes
branch
from
38243f5 to
0f3010c
Compare
justlevine
force-pushed
the
feat/meta-attributes
branch
from
0f3010c to
9e94b89
Compare
|
Rebased post #279 |
theodesp
approved these changes
Sep 20, 2024
|
This was dependent on #284 . I'll rebase that PR to fix the issues surfaced there by @jasonbahl shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for attributes with a
metasource.Important
This PR is based on #284 , which should be merged first.
Relevant diff: 0f3010c
Why
Although
metais considered deprecated, many third-party and legacy blocks still rely on in.Additional Notes
Tests will be backfilled alongside other ongoing work as they require mocking a custom block with a meta field.