Addition of concurrent "running set" alternative to "count" #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add job set tracking
Update resque-concurrent-restriction.rb
Update resque-concurrent-restriction.gemspec
Update resque-concurrent-restriction.gemspec
Configurable Concurrent
Update decrement tracking
Merge pull request #1 from clockhart7/master
random select runnable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this code change is to handle concurrency job count not being decremented after a resque worker dirty exit. This causes restricted concurrent jobs to remain enqueued indefinitely since the code thinks there are jobs being worked on while there actually are not.
Rather than using a running count, a set of jobs is kept, with jobs being added and removed upon start and finish. Each time a job is attempted to be enqueued, a check is done to cross reference the jobs currently being worked on by each worker and the jobs in the running set. Any jobs that are in the running set but not actually being worked on are removed, allowing the restricted check to be done based on the correct number.
The gem still will default to the count configuration so this will not affect current users. To change to the new set configuration, the class accessor "tracking_type" must be set to "set" in the configuration step. Note, the set configuration of the gem will only work when the job args are unique for each job.