Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Itoh integrated Gaunt factors to f-f radiative loss #292

Closed
wants to merge 2 commits into from

Conversation

jwreep
Copy link
Collaborator

@jwreep jwreep commented Aug 15, 2024

Fixes #248

  • Parse the new files
  • Add Itoh options to total f-f Gaunt factor
  • Add Itoh options to f-f radiative loss function
  • Tests

@jwreep
Copy link
Collaborator Author

jwreep commented Aug 15, 2024

For my own reference, the equations from Itoh et al 2002 for the two forms of the Gaunt factor. (They're using log base 10.)

Relativistic:
Screenshot 2024-08-15 at 11 42 37 AM

Non-relativistic:
Screenshot 2024-08-15 at 11 42 56 AM

@wtbarnes
Copy link
Owner

wtbarnes commented Aug 15, 2024

One request before this PR gets too far along. Would you mind making this PR from a branch on your fork other than main? In cases where I need to check out a PR locally, things get a bit confused when the PR branch is also called main. My usual strategy is to create a new branch for every PR.

You should just be able to move all of these commits directly from this branch to a new one and then open a PR from that branch.

@jwreep
Copy link
Collaborator Author

jwreep commented Aug 15, 2024

Yep, will do. Sorry about that!

@jwreep jwreep closed this Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.00%. Comparing base (8ee514b) to head (92853a7).

Files Patch % Lines
fiasco/io/sources/continuum_sources.py 72.72% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
- Coverage   93.14%   93.00%   -0.15%     
==========================================
  Files          37       37              
  Lines        3079     3101      +22     
==========================================
+ Hits         2868     2884      +16     
- Misses        211      217       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use additional Itoh files when computing free-free emission
2 participants