Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant Parameter Cleanup (from PR#110) #136

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Conversation

tmooney
Copy link
Member

@tmooney tmooney commented Oct 23, 2023

This is a replacement version of #110 updated to resolve conflicts that have crept up since that PR was originally created.

Copy link
Member

@chrisamiller chrisamiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 This seems right to me - push all of the defaults down to the lowest level that makes sense.

@malachig
Copy link
Member

I ran a full test with this PR merged. Without manually adjusting any variant freq cutoffs in my YAML file, the germline and somatic variant calls remain the same.

@malachig malachig merged commit 2f7620e into wustl-oncology:main Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants