-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding somatic wgs to dockstore #141
base: main
Are you sure you want to change the base?
Conversation
.dockstore.yml
Outdated
@@ -1,8 +1,8 @@ | |||
version: 1.2 | |||
workflows: | |||
- subclass: WDL | |||
primaryDescriptorPath: /definitions/immuno.wdl | |||
name: immuno | |||
primaryDescriptorPath: /definitions/soamtic_wgs.wdl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- typo in "somatic".
- does changing this to somatic break the immuno dockstore integration? If so, do we need different branches or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(1) ugg!
(2) I am going to rope in @tmooney to weigh in?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you want to make a new entry rather than edit this one, so it ends up like:
workflows:
- subclass: WDL
...etc for immuno...
- subclass: WDL
...etc for somatic_wgs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited Does this look ok?!
That's awfully optimistic 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, that looks like it should work!
Adding somatic wgs to dockstore.