Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding somatic wgs to dockstore #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

adding somatic wgs to dockstore #141

wants to merge 4 commits into from

Conversation

sridhar0605
Copy link
Member

Adding somatic wgs to dockstore.

.dockstore.yml Outdated
@@ -1,8 +1,8 @@
version: 1.2
workflows:
- subclass: WDL
primaryDescriptorPath: /definitions/immuno.wdl
name: immuno
primaryDescriptorPath: /definitions/soamtic_wgs.wdl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. typo in "somatic".
  2. does changing this to somatic break the immuno dockstore integration? If so, do we need different branches or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1) ugg!
(2) I am going to rope in @tmooney to weigh in?!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you want to make a new entry rather than edit this one, so it ends up like:

workflows:
  - subclass: WDL
    ...etc for immuno...
  - subclass: WDL
    ...etc for somatic_wgs...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited Does this look ok?!

@chrisamiller
Copy link
Member

chrisamiller commented Dec 14, 2023

last typo fix in year 2023

That's awfully optimistic 😆

Copy link
Member

@tmooney tmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, that looks like it should work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants