fix(devtools): fix network debug information for ios in chrome devtool (

Tencent#4112)
wwwcg · Nov 6, 2024 · 38d92f8 · 38d92f8
1 parent 0a89614
commit 38d92f8
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/framework/ios/base/executors/HippyJSExecutor.mm b/framework/ios/base/executors/HippyJSExecutor.mm
@@ -265,9 +265,7 @@ - (void)injectDeviceInfoAsHippyNativeGlobal:(HippyBridge *)bridge
                                     context:(const std::shared_ptr<hippy::Ctx> &)context
                                globalObject:(const std::shared_ptr<hippy::CtxValue> &)globalObject {
     NSMutableDictionary *deviceInfo = [NSMutableDictionary dictionaryWithDictionary:[bridge deviceInfo]];
-    NSString *deviceName = [[UIDevice currentDevice] name];
-    NSString *clientId = HippyMD5Hash([NSString stringWithFormat:@"%@%p", deviceName, self]);
-    NSDictionary *debugInfo = @{@"Debug" : @{@"debugClientId" : clientId}};
+    NSDictionary *debugInfo = @{@"Debug" : @{@"debugClientId" : [self getClientID]}};
     [deviceInfo addEntriesFromDictionary:debugInfo];
 
     auto key = context->CreateString(kHippyNativeGlobalKey);
@@ -354,6 +352,12 @@ - (void)registerGetTurboModuleFuncToJS:(const std::shared_ptr<hippy::Ctx> &)cont
 
 #pragma mark -
 
+- (NSString *)getClientID {
+    NSString *deviceName = [[UIDevice currentDevice] name];
+    NSString *clientId = HippyMD5Hash([NSString stringWithFormat:@"%@%p", deviceName, self]);
+    return clientId;
+}
+
 - (void)setUriLoader:(std::weak_ptr<hippy::vfs::UriLoader>)uriLoader {
     if (self.pScope->GetUriLoader().lock() != uriLoader.lock()) {
         self.pScope->SetUriLoader(uriLoader);
@@ -769,9 +773,7 @@ - (NSString *)completeWSURLWithBridge:(HippyBridge *)bridge {
         devInfo.versionId = bundleURLProvider.versionId;
         devInfo.wsURL = bundleURLProvider.wsURL;
     }
-    NSString *deviceName = [[UIDevice currentDevice] name];
-    NSString *clientId = HippyMD5Hash([NSString stringWithFormat:@"%@%p", deviceName, bridge]);
-    return [devInfo assembleFullWSURLWithClientId:clientId contextName:bridge.contextName];
+    return [devInfo assembleFullWSURLWithClientId:[self getClientID] contextName:bridge.contextName];
 }