Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outer join nullable #11

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Outer join nullable #11

wants to merge 7 commits into from

Conversation

wwwouter
Copy link
Owner

@wwwouter wwwouter commented Feb 5, 2020

No description provided.

>
) => void
): ITypedQueryBuilder<
Model,
Copy link

@beem812 beem812 Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit for clarity:

On this and on other joins, this return type overrides any previous joins. By that I mean if I have a table A, and I join table B and then I join table C, when I go to select the columns I want I only have access to columns from table A and table C. This means if I want columns from all three tables I have to join to table B, select columns from it then join to table C and select columns from it. if the return type was ITypedQueryBuilder<Model, AddPropertyWithType<_SelectableModel, NewPropertyKey, NewPropertyType | null>, Row> all joined tables would be selectable when you got to choose what columns you want.

@wwwouter wwwouter mentioned this pull request Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants