Add support to python only pdfviewer for displaying pdf files where not all pages are the same size #2480
Conversation
|
See discussion and review of this PR in #2492 (comment) |
jmoraleda
force-pushed
the
variable-page-size-pdfviewer
branch
from
55020c3
to
7e0e98f
Compare
jmoraleda
force-pushed
the
variable-page-size-pdfviewer
branch
from
7e0e98f
to
87aae0c
Compare
jmoraleda
force-pushed
the
variable-page-size-pdfviewer
branch
from
87aae0c
to
7848269
Compare
…not all pages have the same size
jmoraleda
force-pushed
the
variable-page-size-pdfviewer
branch
from
7848269
to
2dc886a
Compare
|
I wonder if we could merge this in. It has been reviewed thoroughly at See discussion and review of this PR in #2492 (comment). That was an alternative PR for the same feature, and as you can see on the comments, all reviewers including the proponent of that PR agreed that this one was a better implementation. Furthermore it has been thoroughly tested for several months by many people as part of the wxPython-Meticy release: https://pypi.org/project/wxPythonMeticy/ |
|
@Infernio I noticed you worked on the python only pdfviewer recently. Could you by any chance test this PR and provide feedback? Thank you! |
|
I don't use the pure Python one, just the PyMuPDF one. That said, from looking over the commit, it seems fine. |
The current PDF viewer assumes all pages in the PDF document being displayed are of the same size. When this is not the case the PDF does not display correctly.
This PR refactors the viewer so that PDF documents containing pages of different sizes display correctly.
I have thoroughly tested this PR in GTK and MSW and have found it to produce the correct results and have performance comparable to the previous version including for larger documents.