Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not process already-received messages at all #57

Closed
wants to merge 1 commit into from
Closed

Do not process already-received messages at all #57

wants to merge 1 commit into from

Conversation

MetRonnie
Copy link

No description provided.

@MetRonnie MetRonnie mentioned this pull request Aug 11, 2023
Draft
8 tasks
@MetRonnie MetRonnie marked this pull request as draft August 11, 2023 15:49
@MetRonnie
Copy link
Author

MetRonnie commented Aug 11, 2023 •
edited
Loading

tests/functional/restart/28-execution-timeout.t failure is valid and due to execution timeout event not happening. I think it's something to do with the event_time changes in the original PR

Looks like it's due to event handlers that are meant to get set up after receiving the started (polled) message on restart, but aren't on my branch?

image

@MetRonnie
Copy link
Author

Ok, I think the problem is that if we don't go through the mechanism of processing the started (polled) message on restart, the execution timeout is not set up for this run.

cylc/cylc/flow/task_events_mgr.py

Line 1176 in c149bcb

self._reset_job_timers(itask)

@MetRonnie MetRonnie closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MetRonnie