Partially revert changes to Prerequisite
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Oct 31, 2024
Comment on lines
-107
to
-111
| DEP_STATE_SATISFIED: SatisfiedState = 'satisfied naturally' | ||
| DEP_STATE_SATISFIED_BY = 'satisfied by {} mode' | ||
| DEP_STATE_OVERRIDDEN = 'force satisfied' | ||
| DEP_STATE_UNSATISFIED = False | ||
| SATISFIED_MODE_RE = re.compile(r'satisfied by .* mode') |
There was a problem hiding this comment.
Most of these unused, some re-added after being removed in cylc#6293
wxtim
force-pushed
the
feature.skip_mode
branch
2 times, most recently
from
2aa3f1c
to
51f6585
Compare
MetRonnie
force-pushed
the
skip-mode-prereq
branch
from
fc3d674
to
965cbd1
Compare
wxtim
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this plays nicer. I don't think there is a need to have
satisfied by X modewhereXis not "skip".