Fix for prefix detection on IE #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE11 doesn't have any ms-prefixed own-properties in window, so it is necessary to look in window's prototype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for #164. The issue there is that x-tag looks for an
msprefix inwindow, but won't find one there in IE11. On that browser (and presumably IE10 too) it needs to instead look in window's prototype.I've tested this by running the specs on Firefox, Chrome, IE11 and Edge, but not IE<11. The patch uses
Object.getPrototypeOf(), which should be available on IE9+ according to caniuse.I get that this code also needs to work on lots of browsers that I don't have access to, so I've tried to keep the logic similar to what was already there. I did however add a match on
/,(webkit)/before/,(O)/...Happy to iterate on this if you have any feedback.