Cross browser prefix detection #173
Conversation
Updated logic to set prefix so that it works in all browsers.
Merged all matches into a single regex expression
|
@csuwildcat all the checks are now collapsed into a single regexp. Can you have a look when you have some time please? Thanks |
|
Hi @csuwildcat . Did you had the opportunity to have a look at this pull request? Cheers |
|
I did - I had that one last question before merging. Can you take a look and answer for me? |
|
Not sure about the question you're talking about. If not can you point me to the right direction? Thanks |
src/core.js
Outdated
| @@ -33,7 +33,7 @@ | |||
| */ | |||
| prefix = (function () { | |||
| var keys = Object.keys(Object.getPrototypeOf(window)).concat(Object.keys(window)).join(); | |||
There was a problem hiding this comment.
What is the reason for using window,getPrototypeOf() to get the keys from the window prototype? Why doesn't Object.keys(window) alone suffice?
|
Did this make it into the build? |
Updated logic to set prefix so that it works in all browsers.