Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trace service client #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add trace service client #2

wants to merge 5 commits into from

Conversation

korzio
Copy link
Member

@korzio korzio commented Jan 18, 2022 •
edited
Loading

based on https://github.com/open-telemetry/opentelemetry-js/tree/main/examples/grpc-js

  • common server wrapper uses active span, logs traceid and adds a span on top of it
  • both demo-1 and demo services are instances of a server
  • demo-1 additionally creates a context span
  • demo-1 client calls demo service

expected

  • traces are derived

actual

  • traces are shown separate

what's missing?

@korzio korzio changed the base branch from add-trace-service to main January 27, 2022 19:00
@korzio korzio mentioned this pull request Jan 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@korzio