Updates (II) for 1.9.0

CHANGES - updated changelog & readme with security notice - cleaned up obsolete and no longer used files Signed-off-by: x0b <[email protected]>
x0b · Oct 4, 2019 · d22ced5 · d22ced5
1 parent b5bb5a1
commit d22ced5
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 46 deletions.
diff --git a/README.md b/README.md
@@ -1,19 +1,22 @@
->**NOTE:**
->This is a modified build of rcloneExplorer because of little activity in the parent repo. For the parent repository, see [kaczmarkiewiczp/rcloneExplorer](https://github.com/kaczmarkiewiczp/rcloneExplorer).
->
->If you encounter an issue with a [version published here](https://github.com/x0b/rcloneExplorer/releases), [open an issue here](https://github.com/x0b/rcloneExplorer/issues/new). 
-
-
 # RcloneExplorer
 [![license: GPL v3](https://img.shields.io/badge/License-GPLv3-blue.svg)](https://github.com/x0b/rcloneExplorer/blob/master/LICENSE) [![Github Releases](https://img.shields.io/github/downloads/x0b/rcloneExplorer/total.svg)](https://github.com/x0b/rcloneExplorer/releases) [![GitHub release](https://img.shields.io/github/v/release/x0b/rcloneExplorer?include_prereleases)](https://github.com/x0b/rcloneExplorer/releases/latest)
 
 rclone explorer for Android
 
+>**Note:**
+>This is a modified build of rcloneExplorer because of little activity in the parent repo. For the parent repository, see [kaczmarkiewiczp/rcloneExplorer](https://github.com/kaczmarkiewiczp/rcloneExplorer).
+>
+>If you encounter an issue with a [version published here](https://github.com/x0b/rcloneExplorer/releases), [open an issue here](https://github.com/x0b/rcloneExplorer/issues/new). 
+
+## SECURITY NOTICE
+If you are running rcloneExplorer **1.3.5** to **1.8.2**, or AIS-synchro make sure that "Show thumbnails" in ```Settings``` > ```General``` is **disabled** and update to the latest version. If you have not enabled thumbnails, you are not affected.
+More details in [Security Notice 201901: Remote contents readable from local network when browsing any remote with thumbnails enabled](https://github.com/x0b/rcloneExplorer/wiki/Security-Notice-201901-Remote-contents-readable-from-local-network-when-browsing-any-remote-with-thumbnails-enabled).
+
 Features
 --------
 - File Management
     - List and view files
-    - Dowload and upload files
+    - Download and upload files
     - Move, rename, and delete files and folders
 - Streaming & Integration
     - Streaming media files
@@ -44,6 +47,7 @@ Note that these plans are subject to change and might not materialize completely
  - Fix: Crash on LoadingDialog (#7)
  - Fix: Crash on Android 5.1.1 for remotes with time zones (#10)
  - Fix: Crash in hide remotes dialog (#13)
+ - Fix: Security issue when using thumbnails (#18)
 
 #### Next Version
 - New SAF implementation for much faster directory access

diff --git a/app/lib/x86_64/librclone.so b/app/lib/x86_64/librclone.so
diff --git a/app/src/androidTest/java/ca/pkay/rcloneexplorer/ExampleInstrumentedTest.java b/app/src/androidTest/java/ca/pkay/rcloneexplorer/ExampleInstrumentedTest.java
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -43,11 +43,6 @@
                 <action android:name="com.google.firebase.MESSAGING_EVENT"/>
             </intent-filter>
         </service>
-        <service android:name=".Services.FirebaseIdService">
-            <intent-filter>
-                <action android:name="com.google.firebase.INSTANCE_ID_EVENT"/>
-            </intent-filter>
-        </service>
         <service android:name=".Services.ThumbnailsLoadingService" />
         <service android:name=".Services.DeleteService" />
         <service android:name=".Services.MoveService" />

diff --git a/app/src/main/assets/changelog.md b/app/src/main/assets/changelog.md
@@ -6,7 +6,7 @@
 * **Fix:** Crash on LoadingDialog
 * **Fix:** Crash on Android 5.1.1 for remotes with time zones
 * **Fix:** Crash in hide remotes dialog
-
+* **Fix:** Security issue when using thumbnails (details see wiki)
 ***
 
 ### 1.8.2

diff --git a/app/src/main/java/ca/pkay/rcloneexplorer/Fragments/RemotesFragment.java b/app/src/main/java/ca/pkay/rcloneexplorer/Fragments/RemotesFragment.java
@@ -295,7 +295,9 @@ public boolean onMenuItemClick(MenuItem item) {
 
     private void refreshRemotes() {
         remotes = filterRemotes();
-        recyclerViewAdapter.newData(remotes);
+        if (null != recyclerViewAdapter) {
+            recyclerViewAdapter.newData(remotes);
+        }
     }
 
     private List<RemoteItem> filterRemotes() {

diff --git a/app/src/main/java/ca/pkay/rcloneexplorer/Services/FirebaseIdService.java b/app/src/main/java/ca/pkay/rcloneexplorer/Services/FirebaseIdService.java