-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom seasons spanning calendar years #423
Open
tomvothecoder
wants to merge
15
commits into
main
Choose a base branch
from
feature/416-custom-season-span
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+853
−226
Commits on Oct 23, 2024
-
- Remove logic for requiring all 12 months to be used
Configuration menu - View commit details
-
Copy full SHA for b663610 - Browse repository at this point
Copy the full SHA b663610View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f2f575 - Browse repository at this point
Copy the full SHA 3f2f575View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03ff890 - Browse repository at this point
Copy the full SHA 03ff890View commit details -
Configuration menu - View commit details
-
Copy full SHA for 123c57a - Browse repository at this point
Copy the full SHA 123c57aView commit details -
Fix
_drop_incomplete_seasons()
adding dims to variables- Add conditional that determines whether subsetting time coordinates is necessary with custom seasons - Update docstrings for `season_config` - Add tests
Configuration menu - View commit details
-
Copy full SHA for f2004d9 - Browse repository at this point
Copy the full SHA f2004d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a18ab83 - Browse repository at this point
Copy the full SHA a18ab83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b0180f - Browse repository at this point
Copy the full SHA 8b0180fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f45cd6 - Browse repository at this point
Copy the full SHA 8f45cd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6fa508 - Browse repository at this point
Copy the full SHA f6fa508View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6eb54b2 - Browse repository at this point
Copy the full SHA 6eb54b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffd9bbf - Browse repository at this point
Copy the full SHA ffd9bbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 601a055 - Browse repository at this point
Copy the full SHA 601a055View commit details -
Configuration menu - View commit details
-
Copy full SHA for acf1ab9 - Browse repository at this point
Copy the full SHA acf1ab9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c3e8dd - Browse repository at this point
Copy the full SHA 4c3e8ddView commit details
Commits on Oct 24, 2024
-
Refactor logic for shifting months to use Xarray instead of Pandas
- Months are also shifted in the `_preprocess_dataset()` method now. Before months were being shifted twice, once when dropping incomplete seasons or DJF, and a second time when labeling time coordinates.
Configuration menu - View commit details
-
Copy full SHA for 2ff2ba7 - Browse repository at this point
Copy the full SHA 2ff2ba7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.