Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings for add_bounds boolean args #548

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

tomvothecoder
Copy link
Collaborator

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder changed the title Add deperecation warnings for add_bounds boolean args Add deprecation warnings for add_bounds boolean args Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6b45211) 100.00% compared to head (d495499) 100.00%.

❗ Current head d495499 differs from pull request most recent head 73e6851. Consider uploading reports for the commit 73e6851 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #548   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1592      1598    +6     
=========================================
+ Hits          1592      1598    +6     
Files Changed Coverage Δ
xcdat/dataset.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomvothecoder tomvothecoder merged commit 50151e2 into main Sep 14, 2023
7 checks passed
@tomvothecoder tomvothecoder deleted the bug/546-add-bounds-depr-warn branch September 14, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Add deprecation warning if users pass add_bounds=True to open_dataset/open_mfdataset
1 participant