Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR]: Update Regrid2 missing and fill value behaviors to align with CDAT and add
unmapped_to_nan
arg for output data #613[PR]: Update Regrid2 missing and fill value behaviors to align with CDAT and add
unmapped_to_nan
arg for output data #613Changes from 12 commits
715b920
a8e7661
85d1c7c
7e900a0
3743e97
5aeee56
7af50a0
e193c1d
dfc3ebc
646a9a0
6719f03
56f18cb
0b01f79
647a786
79a4cd1
fc17e7a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I extracted this section of code into its own private function and used an explicit for loop to make it more readable compared to list comprehension (IMO).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I don't think Dask Arrays support
np.deg2rad
and/ornp.sin
withnp.nan
values, resulting inValueError: cannot convert float NaN to integer
in #615.