-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR]: Enable skipna
for spatial and temporal mean operations
#655
base: main
Are you sure you want to change the base?
Conversation
skipna
for spatial and temporal mean operations
skipna
for spatial and temporal mean operationsskipna
for spatial and temporal mean operations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1544 1544
=========================================
Hits 1544 1544 ☔ View full report in Codecov by Sentry. |
Test code attached: Archive.zip |
Thanks for this PR @lee1043! I will more closely either some time at the end of this week or early next week. |
@lee1043 – Thanks for taking on this PR. This seems like a handy option to have in xcdat. I just took a quick look at this – it seems like |
@pochedls thanks for the suggestion. I will work on these and ping you and @tomvothecoder for review once ready. |
…erator that fails CI build for python 3.9
…erator that fails CI build for python 3.9 (fixing those missed in the previous commit)
- Add unit tests
I'm assuming that we want to add the |
I think so. This probably needs to be tested on real data (I can't think of unintended consequences, but it is worth stress testing a little). |
Can you upload one of your model validation scripts in the xcdat-validation repo? I would like to re-use it for testing. |
Getting back to this. I don't have an appropriate validation script for this, but may be able to help with this if there is an obvious minimum validation example. For example, is there an equivalent set of CDAT commands that xcdat should be able to match here? I think we would need some reference code to develop a larger model validation script. |
Description
Enable
skipna
parameter for mean operation.Checklist
If applicable: