Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Hartley Rao and other improvements #247

Draft
wants to merge 19 commits into
base: next_release
Choose a base branch
from

Conversation

smishr
Copy link
Contributor

@smishr smishr commented Feb 19, 2023

  • Update docs with add Survey
  • Add back Horvitz thompson total with Hartley Rao variance estimation
  • Integrate HR with total with SurveyDesign
  • Add some analytical formulae for total, deff and other srs formulae
  • Add helper variance functions used in Taylor series linearisation
  • Add tests

I couldnt get R to match Hartley Rao results like for like. R isnt using Hartley Rao algorithm everywhere, only for certain PPS cases. svyrecvar isnt the same as HR.

@smishr smishr added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 19, 2023
@smishr smishr self-assigned this Feb 19, 2023
@smishr smishr changed the title For v0.1.1 release Minor improvements Feb 19, 2023
@smishr smishr changed the title Minor improvements Hartley Rao and other improvements Feb 19, 2023
@ayushpatnaikgit
Copy link
Member

We need to do something about tests. If we can't match answers with R, or any other language, it won't be good to merge this.

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v0.1.1@4fac910). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             v0.1.1     #247   +/-   ##
=========================================
  Coverage          ?   92.66%           
=========================================
  Files             ?       14           
  Lines             ?      218           
  Branches          ?        0           
=========================================
  Hits              ?      202           
  Misses            ?       16           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@smishr smishr changed the title Hartley Rao and other improvements WIP: Hartley Rao and other improvements Feb 24, 2023
@smishr
Copy link
Contributor Author

smishr commented Feb 26, 2023

We need to do something about tests. If we can't match answers with R, or any other language, it won't be good to merge this.

svyrecvar is a beast, but Im confident that a Julia native solution will be much faster, with less overheads.

Also Hartley Rao is good starting point. Better than returning a variance at all

@smishr
Copy link
Contributor Author

smishr commented Mar 14, 2023

@ayushpatnaikgit Should we

  1. Integrate Hartley Rao variance with SurveyDesign. So that the four summary statistics return some variance (instead of nothing)
  2. add tests here

Discussing and adding the Taylor series / recvar might take several months, as well as #277 and other big structural changes will take several months. Until then SurveyDesign will return HR by default? After that we can change default

@smishr smishr deleted the branch xKDR:next_release April 10, 2023 06:02
@smishr smishr closed this Apr 10, 2023
@smishr smishr reopened this Apr 10, 2023
@smishr smishr changed the base branch from v0.1.1 to next_release April 10, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants