Fix invalid use of keyword parameters #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. I used this style to get argument-list checking - you get a warning at compile time if the length is not even. Can I trouble you to add a compiler macro that does the same?On Jun 19, 2023, at 16:01, Marius Gerbershagen ***@***.***> wrote:According to CLHS 3.5.1.5 only symbols are permitted as keys while parameters-alist is called with strings. SBCL doesn't check this but other implementations (e.g. ECL) do.
You can view, comment on, or merge this pull request online at:
#41
Commit Summary
946d515 Fix invalid use of keyword parameters
File Changes (1 file)
M
utils.lisp
(2)
Patch Links:
https://github.com/xach/zs3/pull/41.patch
https://github.com/xach/zs3/pull/41.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
According to CLHS 3.5.1.5 only symbols are permitted as keys while parameters-alist is called with strings. Remove the unnecessary &key and &allow-other-keys.
Sure. I hope this looks better to you now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to CLHS section 3.5.1.5 only symbols are permitted as keys while parameters-alist is called with strings. SBCL doesn't check this but other implementations (e.g. ECL) do.