[CI] Remove stages related to the old pkg signing and notarization.

xamarin · Oct 4, 2024 · 733f954 · 733f954 · vs-mobiletools-engineering-service2 · Oct 4, 2024
1 parent 8bb8f6f
commit 733f954
Show file tree

Hide file tree

Showing 21 changed files with 0 additions and 995 deletions.
diff --git a/tools/devops/automation/build-cronjob.yml b/tools/devops/automation/build-cronjob.yml
@@ -44,12 +44,6 @@ resources:
     ref: refs/heads/main
     endpoint: xamarin
 
-  - repository: release-scripts
-    type: github
-    name: xamarin/release-scripts
-    ref: refs/heads/only_codesign
-    endpoint: xamarin
-
 trigger:
 - main
 

diff --git a/tools/devops/automation/build-lego.yml b/tools/devops/automation/build-lego.yml
@@ -38,12 +38,6 @@ resources:
     ref: refs/heads/main
     endpoint: xamarin
 
-  - repository: release-scripts
-    type: github
-    name: xamarin/release-scripts
-    ref: refs/heads/only_codesign
-    endpoint: xamarin
-
 trigger:
   branches:
     include:

diff --git a/tools/devops/automation/build-pipeline.yml b/tools/devops/automation/build-pipeline.yml
@@ -35,11 +35,6 @@ parameters:
     type: boolean
     default: false
 
-  - name: skipESRP
-    displayName: Skip ESRP
-    type: boolean
-    default: false  # only to be used when testing the CI and we do not need a signed pkg
-
   - name: pushNugets
     type: boolean
     displayName: 'Push Nugets (dotnet)'
@@ -155,12 +150,6 @@ resources:
       ref: refs/heads/main
       endpoint: xamarin
 
-    - repository: release-scripts
-      type: github
-      name: xamarin/release-scripts
-      ref: refs/heads/only_codesign
-      endpoint: xamarin
-
     - repository: CustomPipelineTemplates
       type: git
       name: 1ESPipelineTemplates/MicroBuildTemplate
@@ -231,7 +220,6 @@ extends:
         exclude:
           - repository: yaml-templates
           - repository: sdk-insertions
-          - repository: release-scripts
     stages:
       - template: templates/main-stage.yml
         parameters:
@@ -242,14 +230,9 @@ extends:
           pool: ${{ parameters.pool }}
           runGovernanceTests: ${{ parameters.runGovernanceTests }}
           forceInsertion: ${{ parameters.forceInsertion }}
-          skipESRP: ${{ parameters.skipESRP }}
           pushNugets: ${{ parameters.pushNugets }}
           pushNugetsToMaestro: ${{ parameters.pushNugetsToMaestro }}
           ${{ if ne(length(parameters.testConfigurations), 0)}}:
             testConfigurations: ${{ parameters.testConfigurations }}
           deviceTestsConfigurations: ${{ parameters.deviceTestsConfigurations }}
           macTestsConfigurations: ${{ parameters.macTestsConfigurations }}
-          signingSetupSteps:
-            - template: ./templates/sign-and-notarized/setup.yml
-              parameters:
-                isPR: false
diff --git a/tools/devops/automation/build-pull-request.yml b/tools/devops/automation/build-pull-request.yml
@@ -36,11 +36,6 @@ parameters:
   type: boolean
   default: false 
 
-- name: skipESRP
-  displayName: Skip ESRP
-  type: boolean
-  default: false # only to be used when testing the CI and we do not need a signed pkg
-
 - name: testConfigurations
   displayName: Test configurations to run
   type: object
@@ -146,12 +141,6 @@ resources:
     ref: refs/heads/main
     endpoint: xamarin
 
-  - repository: release-scripts
-    type: github
-    name: xamarin/release-scripts
-    ref: refs/heads/only_codesign
-    endpoint: xamarin
-
   - repository: CustomPipelineTemplates
     type: git
     name: 1ESPipelineTemplates/MicroBuildTemplate
@@ -216,7 +205,6 @@ extends:
         exclude:
         - repository: yaml-templates
         - repository: sdk-insertions
-        - repository: release-scripts
     stages:
     - template: templates/main-stage.yml
       parameters:
@@ -227,14 +215,9 @@ extends:
         pool: ${{ parameters.pool }}
         runGovernanceTests: ${{ parameters.runGovernanceTests }}
         forceInsertion: ${{ parameters.forceInsertion }}
-        skipESRP: ${{ parameters.skipESRP }}
         pushNugets: false
         pushNugetsToMaestro: false
         ${{ if ne(length(parameters.testConfigurations), 0)}}:
           testConfigurations: ${{ parameters.testConfigurations }}
         deviceTestsConfigurations: ${{ parameters.deviceTestsConfigurations }}
         macTestsConfigurations: ${{ parameters.macTestsConfigurations }}
-        signingSetupSteps:
-        - template: ./templates/sign-and-notarized/setup.yml
-          parameters:
-            isPR: true
diff --git a/tools/devops/automation/publish-pr-html-results.yml b/tools/devops/automation/publish-pr-html-results.yml
@@ -29,12 +29,6 @@ resources:
     ref: refs/heads/main
     endpoint: xamarin
 
-  - repository: release-scripts
-    type: github
-    name: xamarin/release-scripts
-    ref: refs/heads/only_codesign
-    endpoint: xamarin
-
   - repository: macios.ci
     type: github
     name: xamarin/macios.ci

diff --git a/tools/devops/automation/scripts/notarize.ps1 b/tools/devops/automation/scripts/notarize.ps1
diff --git a/tools/devops/automation/templates/build/build-pkgs.yml b/tools/devops/automation/templates/build/build-pkgs.yml
@@ -20,10 +20,6 @@ parameters:
     type: boolean
     default: true
 
-  - name: skipESRP
-    type: boolean
-    default: false  # only to be used when testing the CI and we do not need a signed pkg
-
   - name: isPR
     type: boolean
 

diff --git a/tools/devops/automation/templates/build/build-stage.yml b/tools/devops/automation/templates/build/build-stage.yml
@@ -14,10 +14,6 @@ parameters:
   - name: xqaCertPass
     type: string
 
-  - name: skipESRP
-    type: boolean
-    default: false  # only to be used when testing the CI and we do not need a signed pkg
-
   - name: pool
     type: string
     default: automatic
@@ -97,4 +93,3 @@ jobs:
           keyringPass: ${{ parameters.keyringPass }}
           gitHubToken: ${{ parameters.gitHubToken }}
           xqaCertPass: ${{ parameters.xqaCertPass }}
-          skipESRP: ${{ parameters.skipESRP }}
diff --git a/tools/devops/automation/templates/common/checkout.yml b/tools/devops/automation/templates/common/checkout.yml
@@ -36,9 +36,6 @@ steps:
 - checkout: yaml-templates
   clean: true
 
-- checkout: release-scripts
-  clean: true
-
 - pwsh: ./clean_git_vsts.ps1 -GithubToken "$(GitHub.Token)" -MaccorePath "$(System.DefaultWorkingDirectory)/maccore"
   displayName: 'Clean git mess from VSTS'
   workingDirectory: $(System.DefaultWorkingDirectory)/xamarin-macios/tools/devops/automation/scripts
diff --git a/tools/devops/automation/templates/main-stage.yml b/tools/devops/automation/templates/main-stage.yml
@@ -24,10 +24,6 @@ parameters:
     type: boolean
     default: false
 
-  - name: skipESRP
-    type: boolean
-    default: false # only to be used when testing the CI and we do not need a signed pkg
-
   - name: pushNugets
     type: boolean
     default: true # default to true until otherwhise
@@ -159,10 +155,6 @@ parameters:
   - name: macTestsConfigurations
     type: object
 
-  - name: signingSetupSteps
-    type: stepList
-    default: []
-
   - name: legacyPackageJobs
     type: object
     default: [
@@ -264,7 +256,6 @@ stages:
           keyringPass: $(pass--lab--mac--builder--keychain)
           gitHubToken: $(Github.Token)
           xqaCertPass: $(xqa--certificates--password)
-          skipESRP: ${{ parameters.skipESRP }}
           pool: ${{ parameters.pool }}
 
   - stage: build_macos_tests
@@ -284,23 +275,6 @@ stages:
           xqaCertPass: $(xqa--certificates--password)
           pool: ${{ parameters.pool }}
 
-  - stage: prepare_packages_legacy
-    displayName: '${{ parameters.stageDisplayNamePrefix }}Prepare legacy packages'
-    condition: and(eq(dependencies.build_packages.result, 'Succeeded'), eq('${{ parameters.enableLegacySigning }}', true))
-    dependsOn:
-      - build_packages
-      - configure_build
-    jobs:
-      - template: ./sign-and-notarized/prepare-pkg-stage.yml
-        parameters:
-          isPR: ${{ parameters.isPR }}
-          repositoryAlias: ${{ parameters.repositoryAlias }}
-          commit: ${{ parameters.commit }}
-          signingSetupSteps: ${{ parameters.signingSetupSteps }}
-          keyringPass: $(pass--lab--mac--builder--keychain)
-          skipESRP: ${{ parameters.skipESRP }}
-          packages: ${{ parameters.legacyPackageJobs }}
-
   # .NET Release Prep and VS Insertion Stages, only execute them when the build comes from an official branch and is not a schedule build from OneLoc
   # setting the stage at this level makes the graph of the UI look better, else the lines overlap and is not clear.
   - ? ${{ if
@@ -328,19 +302,3 @@ stages:
           commit: ${{ parameters.commit }}
           pushNugets: ${{ parameters.pushNugets }}
           pushNugetsToMaestro: ${{ parameters.pushNugetsToMaestro }}
-
-  - stage: funnel
-    displayName: '${{ parameters.stageDisplayNamePrefix }}Collect signed artifacts'
-    condition: and(eq(dependencies.prepare_packages_legacy.result, 'Succeeded'), eq('${{ parameters.enableLegacySigning }}', true))
-    dependsOn:
-      - prepare_packages_legacy
-      - configure_build
-    jobs:
-      - template: ./sign-and-notarized/funnel.yml
-        parameters:
-          isPR: ${{ parameters.isPR }}
-          repositoryAlias: ${{ parameters.repositoryAlias }}
-          commit: ${{ parameters.commit }}
-          packages:  # flatten the pkgs for the parameter
-            - ${{ each pkg in parameters.legacyPackageJobs }}:
-                - ${{ pkg }}
diff --git a/tools/devops/automation/templates/pipelines/api-diff-pipeline.yml b/tools/devops/automation/templates/pipelines/api-diff-pipeline.yml
@@ -50,12 +50,6 @@ resources:
     ref: refs/heads/main
     endpoint: xamarin
 
-  - repository: release-scripts
-    type: github
-    name: xamarin/release-scripts
-    ref: refs/heads/only_codesign
-    endpoint: xamarin
-
 variables:
 - template: ../variables/common.yml
 - name: DisablePipelineConfigDetector

diff --git a/tools/devops/automation/templates/pipelines/build-pipeline.yml b/tools/devops/automation/templates/pipelines/build-pipeline.yml
@@ -37,11 +37,6 @@ parameters:
   type: boolean
   default: false 
 
-- name: skipESRP
-  displayName: Skip ESRP
-  type: boolean
-  default: false # only to be used when testing the CI and we do not need a signed pkg
-
 - name: pushNugets
   type: boolean
   default: true
@@ -55,10 +50,6 @@ parameters:
   type: boolean
   default: false
 
-- name: signingSetupSteps
-  type: stepList
-  default: []
-
 - name: testConfigurations
   displayName: Test configurations to run
   type: object
@@ -164,13 +155,6 @@ resources:
     ref: refs/heads/main
     endpoint: xamarin
 
-  - repository: release-scripts
-    type: github
-    name: xamarin/release-scripts
-    ref: refs/heads/only_codesign
-    endpoint: xamarin
-
-
 variables:
 - ${{ if eq(parameters.isPR, false) }}:
   - ${{ if contains(variables['Build.DefinitionName'], 'private') }}:
@@ -202,7 +186,6 @@ stages:
     runGovernanceTests: ${{ parameters.runGovernanceTests }}
     enableAPIDiff: ${{ parameters.enableAPIDiff }}
     forceInsertion: ${{ parameters.forceInsertion }}
-    skipESRP: ${{ parameters.skipESRP }}
     pushNugets: ${{ parameters.pushNugets }}
     pushNugetsToMaestro: ${{ parameters.pushNugetsToMaestro }}
     ${{ if ne(length(parameters.testConfigurations), 0)}}:
@@ -211,4 +194,3 @@ stages:
     macTestsConfigurations: ${{ parameters.macTestsConfigurations }}
     azureStorage: ${{ variables['azureStorage'] }}
     azureContainer: ${{ variables['azureContainer'] }}
-    signingSetupSteps: ${{ parameters.signingSetupSteps }}
diff --git a/tools/devops/automation/templates/pipelines/run-macos-tests-pipeline.yml b/tools/devops/automation/templates/pipelines/run-macos-tests-pipeline.yml
@@ -195,12 +195,6 @@ resources:
       ref: refs/heads/main
       endpoint: xamarin
 
-    - repository: release-scripts
-      type: github
-      name: xamarin/release-scripts
-      ref: refs/heads/only_codesign
-      endpoint: xamarin
-
 variables:
   - template: ../variables/common.yml
   - name: DisablePipelineConfigDetector

diff --git a/tools/devops/automation/templates/pipelines/run-tests-pipeline.yml b/tools/devops/automation/templates/pipelines/run-tests-pipeline.yml
@@ -97,12 +97,6 @@ resources:
       ref: refs/heads/main
       endpoint: xamarin
 
-    - repository: release-scripts
-      type: github
-      name: xamarin/release-scripts
-      ref: refs/heads/only_codesign
-      endpoint: xamarin
-
 variables:
   - template: ../variables/common.yml
   - name: DisablePipelineConfigDetector