-
Notifications
You must be signed in to change notification settings - Fork 511
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[msbuild/tests] Use 'dotnet test' for the MSBuild tests. (#21263)
This is another step towards removing Mono. This required a few changes: * Nullability updates in test code. * Explicitly sorted list of strings in a warning message, to make the warning text stable. * Stopped merging system assemblies in the merged tasks assembly. This was necessary for to solve a problem with duplicate types: * The netstandard2.0 version of `System.Reflection.Metadata.dll` contains the `UnconditionalSuppressMessageAttribute` type (internally). * Since we ILMerge the tasks assembly, this type ends up in Xamarin.iOS.Tasks.dll (internally). * The test assembly can't be a net472 assembly, because that means using the netfx/desktop versions of the Microsoft.Build.* assemblies, which don't work on .NET (they check for Mono, but .NET isn't Mono, so the check fails and a PlatformNotSupportedException is thrown). * So I bumped the test assembly to be a net8.0 assembly, but then there's a conflict between the `UnconditionalSuppressMessageAttribute` shipped in .NET vs the one in `Xamarin.iOS.Tasks.dll` (because the test assembly can see the internals of `Xamarin.iOS.Tasks.dll`). * The fix that seems to work is to *not* merge system assemblies in the `Xamarin.iOS.Tasks.dll` assembly. `Xamarin.iOS.Tasks.Windows.dll` already does this, so hopefully there are no problems on Windows, and on macOS our tests doesn't reveal any problems.
- Loading branch information
1 parent
0191ba9
commit a9d82a0
Showing
11 changed files
with
42 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters