[dotnet] Stop suppressing trim analysis warnings. Fixes #21293. #21351

rolfbjarne · 2024-10-01T16:20:33Z

Our own code shouldn't produce trim analysis warnings anymore (see #10405), so
we don't need to suppress trim analysis warnings for everyone.

Fixes #21293.

Our own code shouldn't produce trim analysis warnings anymore (see #10405), so we don't need to suppress trim analysis warnings for everyone. Fixes #21293.

vs-mobiletools-engineering-service2 · 2024-10-01T17:51:18Z

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T18:11:05Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: cceb557d5c14d172af2bb9527c4c6225726c745c [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T18:13:55Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: cceb557d5c14d172af2bb9527c4c6225726c745c [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T18:27:09Z

✅ API diff for current PR / commit

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: cceb557d5c14d172af2bb9527c4c6225726c745c [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T21:44:51Z

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Build macOS tests'

Pipeline on Agent
Hash: cceb557d5c14d172af2bb9527c4c6225726c745c [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T00:25:10Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 21 tests failed, 38 tests passed.

Failures

❌ dotnettests tests (iOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (macOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (tvOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ linker tests

🔥 Failed catastrophically on VSTS: test results - linker (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

4 tests failed, 3 tests passed.

monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug (managed static registrar) [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

4 tests failed, 4 tests passed.

monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
monotouch-test/Mac Catalyst [dotnet]/Release (static registrar) [dotnet]: BuildFailure
monotouch-test/Mac Catalyst [dotnet]/Release (managed static registrar) [dotnet]: BuildFailure
monotouch-test/Mac Catalyst [dotnet]/Debug (managed static registrar) [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

5 tests failed, 4 tests passed.

monotouch-test/Mac [dotnet]/Debug [dotnet]: BuildFailure
monotouch-test/Mac [dotnet]/Debug (static registrar) [dotnet]: BuildFailure ( (failed to parse the logs: The Writer is closed or in error state.))
monotouch-test/Mac [dotnet]/Release (static registrar) [dotnet]: BuildFailure
monotouch-test/Mac [dotnet]/Release (managed static registrar) [dotnet]: BuildFailure
monotouch-test/Mac [dotnet]/Debug (managed static registrar) [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

4 tests failed, 3 tests passed.

monotouch-test/tvOS - simulator/Debug [dotnet]: BuildFailure
monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: BuildFailure
monotouch-test/tvOS - simulator/Debug (managed static registrar) [dotnet]: BuildFailure

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: cceb557d5c14d172af2bb9527c4c6225726c745c [PR build]

…sion

vs-mobiletools-engineering-service2 · 2024-10-04T16:42:41Z

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Build macOS tests'

Pipeline on Agent
Hash: 7c68741c925ac2f62771f009f58a7286cf01b4d7 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-04T17:09:44Z

✅ API diff for current PR / commit

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7c68741c925ac2f62771f009f58a7286cf01b4d7 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-04T17:19:59Z

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-10-04T17:38:21Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 7c68741c925ac2f62771f009f58a7286cf01b4d7 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-04T19:37:19Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 24 tests failed, 75 tests passed.

Failures

❌ dotnettests tests (iOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (macOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (tvOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ fsharp tests

1 tests failed, 3 tests passed.

fsharp/iOS Unified 64-bits - simulator/Debug [dotnet]: HarnessException (Harness exception for 'fsharp': System.AggregateException: One or more errors occurred. (A task was canceled.)
---> System.Threading.Tasks.TaskCanceledException: A task was canceled.
at System.Threading.Tasks.Task.GetExceptions(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task1.get_Result() at Microsoft.DotNet.XHarness.iOS.Shared.TestReporter.get_TestExecutionStarted() at Microsoft.DotNet.XHarness.iOS.Shared.TestReporter.ParseResult() at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine) at Microsoft.DotNet.XHarness.iOS.Shared.TestReporter.ParseResult() at Xharness.AppRunner.RunAsync() in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/AppRunner.cs:line 453 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetResult(TResult result)
at Microsoft.DotNet.XHarness.Common.Execution.ProcessManager.ExecuteCommandAsync(String filename, IList1 args, ILog log, ILog stdout, ILog stderr, TimeSpan timeout, Dictionary2 environmentVariables, Nullable1 cancellationToken) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.ExecutionContextCallback(Object s) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext() at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at Microsoft.DotNet.XHarness.Common.Execution.ProcessManager.RunAsyncInternal(Process process, ILog log, ILog stdout, ILog stderr, Action2 kill, Func3 getChildProcessIds, Nullable1 timeout, Dictionary2 environmentVariables, Nullable1 cancellationToken, Nullable1 diagnostics) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.ExecutionContextCallback(Object s) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext() at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at Microsoft.DotNet.XHarness.Common.Execution.ProcessManager.WaitForExitAsync(Process process, Nullable1 timeout)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.ExecutionContextCallback(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext()
at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining)
at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
at Microsoft.DotNet.XHarness.Common.Utilities.Extensions.TimeoutAfter[T](Task1 task, TimeSpan timeout) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.ExecutionContextCallback(Object s) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext() at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task1.TrySetResult(TResult result)
at System.Threading.Tasks.Task.TwoTaskWhenAnyPromise1.Invoke(Task completingTask) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.TaskCompletionSource1.TrySetResult(TResult result)
at Microsoft.DotNet.XHarness.Common.Execution.ProcessManager.<>c__DisplayClass11_0.g__ProcessExited|0(Object sender, EventArgs ea)
at System.Diagnostics.Process.RaiseOnExited()
at System.Diagnostics.Process.CompletionCallback(Object waitHandleContext, Boolean wasSignaled)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.PortableThreadPool.CompleteWait(RegisteredWaitHandle handle, Boolean timedOut)
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
at System.Threading.Thread.StartCallback()
--- End of stack trace from previous location ---
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task`1.get_Result()
at Microsoft.DotNet.XHarness.iOS.Shared.TestReporter.get_TestExecutionStarted()
at Microsoft.DotNet.XHarness.iOS.Shared.TestReporter.ParseResult()
at Xharness.AppRunner.RunAsync() in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/AppRunner.cs:line 453
at Xharness.Jenkins.TestTasks.RunSimulator.RunTestAsync() in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/RunSimulator.cs:line 128
at Xharness.Jenkins.TestTasks.RunTest.ExecuteAsync() in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/RunTest.cs:line 113
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync() in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:line 245)

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

6 tests failed, 1 tests passed.

monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations) [dotnet]: TimedOut
monotouch-test/iOS Unified 64-bits - simulator/Debug (managed static registrar) [dotnet]: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Release (managed static registrar, all optimizations) [dotnet]: TimedOut

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

4 tests failed, 4 tests passed.

monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
monotouch-test/Mac Catalyst [dotnet]/Release (static registrar) [dotnet]: BuildFailure
monotouch-test/Mac Catalyst [dotnet]/Release (managed static registrar) [dotnet]: BuildFailure
monotouch-test/Mac Catalyst [dotnet]/Debug (managed static registrar) [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

5 tests failed, 4 tests passed.

monotouch-test/Mac [dotnet]/Debug [dotnet]: BuildFailure
monotouch-test/Mac [dotnet]/Debug (static registrar) [dotnet]: BuildFailure
monotouch-test/Mac [dotnet]/Release (static registrar) [dotnet]: BuildFailure
monotouch-test/Mac [dotnet]/Release (managed static registrar) [dotnet]: BuildFailure
monotouch-test/Mac [dotnet]/Debug (managed static registrar) [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

4 tests failed, 3 tests passed.

monotouch-test/tvOS - simulator/Debug [dotnet]: BuildFailure
monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: BuildFailure
monotouch-test/tvOS - simulator/Debug (managed static registrar) [dotnet]: BuildFailure

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 7c68741c925ac2f62771f009f58a7286cf01b4d7 [PR build]

[dotnet] Stop suppressing trim analysis warnings. Fixes #21293.

cceb557

Our own code shouldn't produce trim analysis warnings anymore (see #10405), so we don't need to suppress trim analysis warnings for everyone. Fixes #21293.

rolfbjarne added the do-not-merge Do not merge this pull request label Oct 1, 2024

This comment has been minimized.

Sign in to view

rolfbjarne changed the base branch from net9.0 to main October 4, 2024 08:08

rolfbjarne removed the do-not-merge Do not merge this pull request label Oct 4, 2024

Merge branch 'main' into dev/rolf/dev/rolf/no-trimmer-warning-suppres…

7c68741

…sion

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dotnet] Stop suppressing trim analysis warnings. Fixes #21293. #21351

[dotnet] Stop suppressing trim analysis warnings. Fixes #21293. #21351

rolfbjarne commented Oct 1, 2024 •

edited

Loading

vs-mobiletools-engineering-service2 commented Oct 1, 2024

vs-mobiletools-engineering-service2 commented Oct 1, 2024

vs-mobiletools-engineering-service2 commented Oct 1, 2024

vs-mobiletools-engineering-service2 commented Oct 1, 2024

vs-mobiletools-engineering-service2 commented Oct 1, 2024

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 2, 2024

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 4, 2024

vs-mobiletools-engineering-service2 commented Oct 4, 2024

vs-mobiletools-engineering-service2 commented Oct 4, 2024

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 4, 2024

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 4, 2024

[dotnet] Stop suppressing trim analysis warnings. Fixes #21293. #21351

Are you sure you want to change the base?

[dotnet] Stop suppressing trim analysis warnings. Fixes #21293. #21351

Conversation

rolfbjarne commented Oct 1, 2024 • edited Loading

vs-mobiletools-engineering-service2 commented Oct 1, 2024

📚 [CI Build] Artifacts 📚

vs-mobiletools-engineering-service2 commented Oct 1, 2024

❌ [CI Build] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Oct 1, 2024

❌ [CI Build] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Oct 1, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 1, 2024

🔥 [CI Build] Build failed 🔥

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 2, 2024

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ dotnettests tests (iOS)

❌ dotnettests tests (MacCatalyst)

❌ dotnettests tests (macOS)

❌ dotnettests tests (tvOS)

❌ linker tests

❌ monotouch tests (iOS)

❌ monotouch tests (MacCatalyst)

❌ monotouch tests (macOS)

❌ monotouch tests (tvOS)

Successes

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 4, 2024

🔥 [CI Build] Build failed 🔥

vs-mobiletools-engineering-service2 commented Oct 4, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 4, 2024

📚 [CI Build] Artifacts 📚

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 4, 2024

❌ [CI Build] Windows Integration Tests failed ❌

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 4, 2024

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ dotnettests tests (iOS)

❌ dotnettests tests (MacCatalyst)

❌ dotnettests tests (macOS)

❌ dotnettests tests (tvOS)

❌ fsharp tests

❌ monotouch tests (iOS)

❌ monotouch tests (MacCatalyst)

❌ monotouch tests (macOS)

❌ monotouch tests (tvOS)

Successes

rolfbjarne commented Oct 1, 2024 •

edited

Loading