CA-400860: rrdp-netdev - drop xenctrl, use xenstore to get UUIDs from domids instead #6068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Oct 22, 2024
| (Printf.sprintf "Failed to find uuid corresponding to domid: %d" domid) | ||
| in | ||
| uuid | ||
| let uuid_of_domid domid = |
There was a problem hiding this comment.
Are there any other plugins that use this pattern? They could share code in the plugin library that you added
There was a problem hiding this comment.
xenops_helpers has the same function
There was a problem hiding this comment.
yes, it's where i stole the function from. but xenops_helpers also converts strings to UUIDs, which I don't need.
lindig
approved these changes
Oct 22, 2024
| xs.Xenstore.Xs.read (vm_dir ^ "/uuid") | ||
| ) | ||
| with _ -> | ||
| failwith |
There was a problem hiding this comment.
let fail = Printf.ksprintf failwith (* somewhere at the top of the file *)
..
fail "Something %s" "a string"
Might want to log the exception to understand why this fails. I would use Filename.concat to construct the paths but it's a aesthetic choice.
There was a problem hiding this comment.
This should be Xenstore.Path.concat or similar, since they are not filenames
… domids instead Signed-off-by: Andrii Sultanov <[email protected]>
last-genius
force-pushed
the
private/asultanov/rrdd-xenctrl-fix
branch
from
537904f
to
1bdb22a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the fix we had to rush, dropping xenctrl entirely.
Tested with a Windows VM, the domain creation is picked up and network metrics are present for it, with correct UUIDs determined.