Add python3 examples for letor #26
Conversation
|
Nothing actually references this new example so it won't appear anywhere in the documentation. Also, generating the documentation runs the example code to check it actually works and produces the claimed results, so adding letor examples here would make letor (and so libsvm, etc) a requirement, which seems a bit undesirable. Letor is also a somewhat more advanced topic, so perhaps we should have a separate "volume" for letor which can be built separately. |
I guess ayush_pandey has fixed all these issues in #18. This PR is supposed to be merged after #18 hence I don't think the above issues would be a problem. |
The "not appearing in" remains a problem, and when you do that you'll have to include expected output. The solution to depending on #18 is a bit fiddly — you can open a PR against @AyushP123's branch underlying #18 — so it's probably easiest to focus attention on getting #18 merged, then this can just merge to master. @ojwb I actually wouldn't have a problem with a "full" build run requiring letor, since (if I remember correctly) inability to run the examples doesn't change the output, just causes build warnings that the output is different. |
|
If the result of letor not being available is the same manual being generated plus some additional warnings, I guess that's OK (at least if the warnings are clear as to what's going on - if they mislead people to think there's a problem that will just generate support load). But yes, we should get #18 tidied up and merged first. Unfortunately there are still a few outstanding issues with it. |
No description provided.