perf: avoid redundant data when saving Rotator models #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicrie
changed the title
nicrie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves disk space efficiency when saving the
Rotator. Previously, the entire model, including itsPreprocessorandWhitener, was saved twice -- once for the original model and once for the Rotator. This resulted in redundant storage, particularly for theWhitener, which can be large due to its transformation matrix.To address this, the PR no longer saves the entire original model. Instead, it creates a
DataContainerfor the original model and only copies the necessaryDataArraysrequired by the Rotator, avoiding duplicate data.