Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct whitening in HilbertCPCCA models #230

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Conversation

nicrie
Copy link
Contributor

@nicrie nicrie commented Sep 13, 2024

During the data preprocessing of the Hilbert CPCCA model the data was first whitened and then Hilbert transformed. The final Hilbert transform destroyed the whitening property of the data. The correct order should be Hilbert transform -> Whitening.

In order to fix this we refactor the Whitener into two classes, a PCA preprocessor and a pure Whitener. Then we move the data augmentation step in between the PCA and Whitener step.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 16.44737% with 127 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@bcbaa9e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
xeofs/preprocessing/pca.py 27.39% 53 Missing ⚠️
xeofs/cross/cpcca.py 0.00% 26 Missing ⚠️
xeofs/cross/base_model_cross_set.py 5.00% 19 Missing ⚠️
xeofs/preprocessing/whitener.py 8.33% 11 Missing ⚠️
xeofs/cross/cpcca_rotator.py 9.09% 10 Missing ⚠️
xeofs/single/pop.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #230   +/-   ##
==========================================
  Coverage           ?   24.58%           
==========================================
  Files              ?       59           
  Lines              ?     4047           
  Branches           ?        0           
==========================================
  Hits               ?      995           
  Misses             ?     3052           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicrie nicrie merged commit 3ba531c into develop Sep 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant