Stop quoting column default values #200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a column to a table (either at creation time or afterwards with an alter table migration), any default value for the column is automatically single quoted.
This makes it easier to define migrations, as the user does not have to remember to add the single quotes in the migration.
For example in this migration:
the default value for the
name
column (unnamed
) does not need to be quoted aspgroll
does that automatically.However, this automatic quoting causes a problem when assigning a default value of
now()
to a timestamp column:when run, this will result in a
created_at
column with a default value of the time at which the migration was run, eg:rather than the desired default:
This PR removes the automatic quoting of default values so that
now()
,CURRENT_TIMESTAMP
etc can be used correctly as column defaults. This pushes some complexity onto users who now have to single-quote those default values that require it.