Allow some named inline column constraints in CREATE TABLE statements
#559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
changed the base branch from
main
to
fix-alter-table-add-column-expectations
andrew-farries
force-pushed
the
allow-named-inline-constraints-in-create-table
branch
from
0e8a35a to
904fbce
Compare
ryanslade
reviewed
Jan 2, 2025
ryanslade
approved these changes
Jan 2, 2025
Base automatically changed from
fix-alter-table-add-column-expectations
to
main
January 2, 2025 09:06
andrew-farries
force-pushed
the
allow-named-inline-constraints-in-create-table
branch
from
904fbce to
3b0170c
Compare
Allow some named inline column constraints in `CREATE TABLE` statements. SQL like this can be converted to a pgroll `Column`: ```sql CREATE TABLE foo(a int CONSTRAINT my_check CHECK (a > 0)) CREATE TABLE foo(a int CONSTRAINT my_fk REFERENCES bar(b)) ``` The previous behaviour was to allow only the unamed forms of these: ```sql CREATE TABLE foo(a int CHECK (a > 0)) CREATE TABLE foo(a int REFERENCES bar(b)) ``` Named inline column constraints remain unsupported for `DEFAULT`, `NULL`, `NOT NULL`, `UNIQUE` and `PRIMARY KEY` constraints.
andrew-farries
force-pushed
the
allow-named-inline-constraints-in-create-table
branch
from
3b0170c to
d976256
Compare
andrew-farries
deleted the
allow-named-inline-constraints-in-create-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow some named inline column constraints in
CREATE TABLEstatements.SQL like this can be converted to a pgroll
OpCreateTable:The previous behaviour was to allow only the unnamed forms of these constraints:
Named inline column constraints remain unsupported for
DEFAULT,NULL,NOT NULL,UNIQUEandPRIMARY KEYconstraints and will fall back to a raw SQL operation.