Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original table name without prefix when processing create table #572

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

agedemenli
Copy link
Contributor

@agedemenli agedemenli commented Jan 7, 2025

Using the original name, instead of calling TemporaryName which adds the prefix _pgroll_new_ in create table operations and also when rolling back.
Includes necessary changes in tests.
Fixes: #571

@agedemenli agedemenli force-pushed the create-table-name-without-prefix branch 2 times, most recently from 96fd516 to 832f205 Compare January 8, 2025 08:59
@agedemenli agedemenli force-pushed the create-table-name-without-prefix branch from 832f205 to 9a391ec Compare January 8, 2025 09:15
@agedemenli agedemenli marked this pull request as ready for review January 8, 2025 09:31
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 👍

pkg/migrations/op_create_table.go Outdated Show resolved Hide resolved
@agedemenli agedemenli force-pushed the create-table-name-without-prefix branch from 2e4fa45 to ea20bd0 Compare January 8, 2025 14:34
@agedemenli agedemenli enabled auto-merge (squash) January 8, 2025 14:34
@agedemenli agedemenli merged commit bd0fa1c into main Jan 8, 2025
27 checks passed
@agedemenli agedemenli deleted the create-table-name-without-prefix branch January 8, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pgroll prefixes remain on index names after migration is completed
2 participants