Remove the ability to rename columns with alter_column operations
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
force-pushed
the
remove-rename-from-alter-column
branch
2 times, most recently
from
31866a2 to
b3532cf
Compare
kvch
approved these changes
Jan 17, 2025
Most of the complexity of the `OpAlterColumn` operation was due to handling renames in the same operation as other column changes. Now that it's no longer possible to rename a column via `OpAlterColumn` most of these JSON schema tests are no longer required.
The test used to rename a column, unnecessarily. Change the test so that it no longer renames a column, and update the test expectations so that it better tests the renaming of a (`CHECK`) constraint.
Move the `OpAlterColumn` tests that test the column rename operation in combination with other operations to `OpRenameColumn` tests. The tests are idenitical, with `OpAlterColumn` replaced with `OpRenameColumn`.
andrew-farries
force-pushed
the
remove-rename-from-alter-column
branch
from
b3532cf to
9d26a4e
Compare
kvch
pushed a commit
to kvch/pgroll
that referenced
this pull request
Jan 20, 2025
…ataio#603) Remove the ability to rename columns with `alter_column` operations. xataio#602 added the `rename_column` operation as the preferred way to rename columns: ```json { "name": "13_rename_column", "operations": [ { "rename_column": { "table": "employees", "from": "role", "to": "job_title" } } ] } ``` As of this PR, `rename_column` operations are the only way to rename columns, with the ability to do so using `alter_column` operations removed. This is a breaking change to the `pgroll` migrations format. This is the second (and final) part of xataio#601 Closes xataio#601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ability to rename columns with
alter_columnoperations.#602 added the
rename_columnoperation as the preferred way to rename columns:{ "name": "13_rename_column", "operations": [ { "rename_column": { "table": "employees", "from": "role", "to": "job_title" } } ] }As of this PR,
rename_columnoperations are the only way to rename columns, with the ability to do so usingalter_columnoperations removed.This is a breaking change to the
pgrollmigrations format.This is the second (and final) part of #601
Closes #601