Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin.video.eitb] 3.0.0 #4240

Open
wants to merge 1 commit into
base: nexus
Choose a base branch
from
Open

[plugin.video.eitb] 3.0.0 #4240

wants to merge 1 commit into from

Conversation

erral
Copy link

@erral erral commented Feb 5, 2023

Description

Upgrade of the plugin to work with the new version of the API

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

enen92
enen92 requested changes Feb 15, 2023
View reviewed changes
plugin.video.eitb/.gitignore Outdated
@@ -0,0 +1,89 @@
# Byte-compiled / optimized / DLL files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove from the submission

plugin.video.eitb/addon.xml Outdated
<description lang="en_GB">Plugin for EITB using the unofficial REST API</description>
<summary lang="eu">EITB Nahieranentzako plugina</summary>
<description lang="eu">EITB Nahieranen API ez ofiziala erabiliz egindakoa</description>
<summary lang="es">Plugin para EITB a la carta</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es_ES?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous version worked perfectly using only 'es', just the language without country signal...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and? Kodi v14 and older uses ISO-639 code, which have been updated since then (it works due to backwards compatibility but no guarantees it will work forever).

See: https://kodi.wiki/view/Addon.xml

Please update as advised

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to be es_ES

plugin.video.eitb/addon.xml Outdated
<summary lang="eu">EITB Nahieranentzako plugina</summary>
<description lang="eu">EITB Nahieranen API ez ofiziala erabiliz egindakoa</description>
<summary lang="es">Plugin para EITB a la carta</summary>
<description lang="es">Hecho con la API no oficial de EITB a la carta</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es_ES

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

plugin.video.eitb/addon.xml Show resolved Hide resolved
plugin.video.eitb/resources/language/resource.language.en_gb/strings.po
@@ -0,0 +1,39 @@
# Kodi Media Center language file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make the history icon smaller?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

plugin.video.eitb/resources/language/resource.language.eu_es/strings.po Show resolved Hide resolved
plugin.video.eitb/video.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enen92 enen92 enen92 requested changes

Assignees
No one assigned
Labels
waiting for developer to respond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erral @enen92